Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Remove unused constructor parameter and unused member variables

Browse source 
Make member variables private

Change-Id: Ie76f30a5c5731529256b2b160f6dde4d49646545
This commit is contained in:
Reedy 2019-04-14 02:36:34 +01:00
parent 6f4d15e385
commit c5a438e9de
2 changed files with 4 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
includes/api/ApiFeedRecentChanges.php
View file

@ -101,7 +101,7 @@ class ApiFeedRecentChanges extends ApiBase {
$this->dieWithError( [ 'apierror-invalidtitle', wfEscapeWikiText( $this->params['target'] ) ] );
}
$feed = new ChangesFeed( $feedFormat, false );
$feed = new ChangesFeed( $feedFormat );
$feedObj = $feed->getFeedObject(
$this->msg( 'recentchangeslinked-title', $title->getPrefixedText() )
->inContentLanguage()->text(),
@ -109,7 +109,7 @@ class ApiFeedRecentChanges extends ApiBase {
SpecialPage::getTitleFor( 'Recentchangeslinked' )->getFullURL()
);
} else {
$feed = new ChangesFeed( $feedFormat, 'rcfeed' );
$feed = new ChangesFeed( $feedFormat );
$feedObj = $feed->getFeedObject(
$this->msg( 'recentchanges' )->inContentLanguage()->text(),
$this->msg( 'recentchanges-feed-description' )->inContentLanguage()->text(),

6
includes/changes/ChangesFeed.php
View file

@ -26,15 +26,13 @@
* @ingroup Feed
*/
class ChangesFeed {
public $format, $type, $titleMsg, $descMsg;
private $format;
/**
* @param string $format Feed's format (either 'rss' or 'atom')
* @param string $type Type of feed (for cache keys)
*/
public function __construct( $format, $type ) {
public function __construct( $format ) {
$this->format = $format;
$this->type = $type;
}
/**