From 3275ef7f5e74401d06163ad2ee1118fec1440e0b Mon Sep 17 00:00:00 2001 From: DannyS712 Date: Thu, 12 Mar 2020 00:22:31 +0000 Subject: [PATCH] Tests: Remove unneeded uses of global $wgUser Tests still pass -> wgUser isn't needed Bug: T243708 Change-Id: I931f01bc132a5777c27a4296a14fd734a23ca099 --- tests/phpunit/includes/content/CssContentTest.php | 5 ----- tests/phpunit/includes/content/TextContentTest.php | 1 - tests/phpunit/includes/language/ConverterRuleTest.php | 5 ----- 3 files changed, 11 deletions(-) diff --git a/tests/phpunit/includes/content/CssContentTest.php b/tests/phpunit/includes/content/CssContentTest.php index db946742edd..9823c635584 100644 --- a/tests/phpunit/includes/content/CssContentTest.php +++ b/tests/phpunit/includes/content/CssContentTest.php @@ -12,12 +12,7 @@ class CssContentTest extends JavaScriptContentTest { protected function setUp() : void { parent::setUp(); - // Anon user - $user = new User(); - $user->setName( '127.0.0.1' ); - $this->setMwGlobals( [ - 'wgUser' => $user, 'wgTextModelsToParse' => [ CONTENT_MODEL_CSS, ] diff --git a/tests/phpunit/includes/content/TextContentTest.php b/tests/phpunit/includes/content/TextContentTest.php index d1d0ddd83d0..f511d3eaa0f 100644 --- a/tests/phpunit/includes/content/TextContentTest.php +++ b/tests/phpunit/includes/content/TextContentTest.php @@ -26,7 +26,6 @@ class TextContentTest extends MediaWikiLangTestCase { $this->context->setUser( $user ); $this->setMwGlobals( [ - 'wgUser' => $user, 'wgTextModelsToParse' => [ CONTENT_MODEL_WIKITEXT, CONTENT_MODEL_CSS, diff --git a/tests/phpunit/includes/language/ConverterRuleTest.php b/tests/phpunit/includes/language/ConverterRuleTest.php index 2c7f3fc5e5b..79567c3ac7e 100644 --- a/tests/phpunit/includes/language/ConverterRuleTest.php +++ b/tests/phpunit/includes/language/ConverterRuleTest.php @@ -5,11 +5,6 @@ */ class ConverterRuleTest extends MediaWikiTestCase { - public function setUp() : void { - parent::setUp(); - $this->setMwGlobals( 'wgUser', new User ); - } - public function testParseEmpty() { $converter = new EnConverter( new Language() ); $rule = new ConverterRule( '', $converter );