Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Mock IDatabase::class instead of Database::class

Browse source 
Change-Id: I960bfdd5c9738c201a1be3ccaae05efc3d176ea8
This commit is contained in:
Umherirrender 2019-05-01 17:31:13 +02:00 committed by Thiemo Kreuz (WMDE)
parent cd43e666a0
commit c6fe2baea9
1 changed files with 4 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
tests/phpunit/includes/watcheditem/WatchedItemQueryServiceUnitTest.php
View file

@ -1,5 +1,6 @@
<?php
use Wikimedia\Rdbms\IDatabase;
use Wikimedia\Rdbms\LoadBalancer;
use Wikimedia\TestingAccessWrapper;
@ -78,12 +79,10 @@ class WatchedItemQueryServiceUnitTest extends MediaWikiTestCase {
}
/**
* @return PHPUnit_Framework_MockObject_MockObject|Database
* @return PHPUnit_Framework_MockObject_MockObject|IDatabase
*/
private function getMockDb() {
$mock = $this->getMockBuilder( Database::class )
->disableOriginalConstructor()
->getMock();
$mock = $this->createMock( IDatabase::class );
$mock->expects( $this->any() )
->method( 'makeList' )
@ -126,7 +125,7 @@ class WatchedItemQueryServiceUnitTest extends MediaWikiTestCase {
}
/**
* @param PHPUnit_Framework_MockObject_MockObject|Database $mockDb
* @param PHPUnit_Framework_MockObject_MockObject|IDatabase $mockDb
* @return PHPUnit_Framework_MockObject_MockObject|LoadBalancer
*/
private function getMockLoadBalancer( $mockDb ) {
@ -141,7 +140,6 @@ class WatchedItemQueryServiceUnitTest extends MediaWikiTestCase {
}
/**
* @param PHPUnit_Framework_MockObject_MockObject|Database $mockDb
* @return PHPUnit_Framework_MockObject_MockObject|WatchedItemStore
*/
private function getMockWatchedItemStore() {