diff --git a/RELEASE-NOTES b/RELEASE-NOTES index da9a2172394..9b814c5a49a 100644 --- a/RELEASE-NOTES +++ b/RELEASE-NOTES @@ -157,6 +157,8 @@ it from source control: http://www.mediawiki.org/wiki/Download_from_SVN pages which had spaces in theirs names * If restricted read access was enabled, requests for non-existing special pages threw an exception +* Feeds for recent changes now provide correct URLs for the change, not just + the page === API changes in 1.12 === diff --git a/includes/Feed.php b/includes/Feed.php index ed4343c31bf..503b43bdce2 100644 --- a/includes/Feed.php +++ b/includes/Feed.php @@ -41,6 +41,7 @@ class FeedItem { /**#@+ * @todo document + * @param $Url URL uniquely designating the item. */ function __construct( $Title, $Description, $Url, $Date = '', $Author = '', $Comments = '' ) { $this->Title = $Title; diff --git a/includes/SpecialRecentchanges.php b/includes/SpecialRecentchanges.php index 2744cd8f559..4fae63511e1 100644 --- a/includes/SpecialRecentchanges.php +++ b/includes/SpecialRecentchanges.php @@ -379,9 +379,12 @@ function rcOutputFeed( $rows, $feedFormat, $limit, $hideminor, $lastmod ) { return true; } +/** + * @todo document + * @param $rows Database resource with recentchanges rows + */ function rcDoOutputFeed( $rows, &$feed ) { - $fname = 'rcDoOutputFeed'; - wfProfileIn( $fname ); + wfProfileIn( __METHOD__ ); $feed->outHeader(); @@ -406,7 +409,7 @@ function rcDoOutputFeed( $rows, &$feed ) { $item = new FeedItem( $title->getPrefixedText(), rcFormatDiff( $obj ), - $title->getFullURL(), + $title->getFullURL( 'diff=' . $obj->rc_this_oldid . '&oldid=prev' ), $obj->rc_timestamp, $obj->rc_user_text, $talkpage->getFullURL() @@ -414,7 +417,7 @@ function rcDoOutputFeed( $rows, &$feed ) { $feed->outItem( $item ); } $feed->outFooter(); - wfProfileOut( $fname ); + wfProfileOut( __METHOD__ ); } /**