Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Remove unused static methods in LanguageConverter subclasses

Browse source 
It seems LanguageConverter::parseManualRule was removed by
69dbeb97f1 (2008),
and LanguageConverter::parserConvert by
c568220e61 (2010),
so it seems safe and reasonable to remove their implementations
from few remaining language-specific Converter classes.

Change-Id: I7092f5c8856723fabd2b1f99944451344feb5711
This commit is contained in:
Leszek Manicki 2017-01-03 15:13:51 +01:00
parent daba6753d1
commit cb4bb23df6
5 changed files with 1 additions and 127 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

38
languages/classes/LanguageIu.php
View file

@ -96,44 +96,6 @@ class IuConverter extends LanguageConverter {
];
}
/**
* rules should be defined as -{Syllabic | Latin-} -or-
* -{code:text | code:text | ...}-
* update: delete all rule parsing because it's not used
* currently, and just produces a couple of bugs
*
* @param string $rule
* @param array $flags
* @return array
*/
function parseManualRule( $rule, $flags = [] ) {
if ( in_array( 'T', $flags ) ) {
return parent::parseManualRule( $rule, $flags );
}
$carray = [];
// otherwise ignore all formatting
foreach ( $this->mVariants as $v ) {
$carray[$v] = $rule;
}
return $carray;
}
/**
* Do not convert content on talk pages
*
* @param string $text
* @param Parser $parser
* @return string
*/
function parserConvert( $text, &$parser ) {
$this->mDoContentConvert = !( is_object( $parser->getTitle() )
&& $parser->getTitle()->isTalkPage() );
return parent::parserConvert( $text, $parser );
}
/**
* A function wrapper:
* - if there is no selected variant, leave the link

25
languages/classes/LanguageKk.php
View file

@ -216,31 +216,6 @@ class KkConverter extends LanguageConverter {
];
}
/**
* rules should be defined as -{ekavian | iyekavian-} -or-
* -{code:text | code:text | ...}-
*
* update: delete all rule parsing because it's not used
* currently, and just produces a couple of bugs
*
* @param string $rule
* @param array $flags
* @return array
*/
function parseManualRule( $rule, $flags = [] ) {
if ( in_array( 'T', $flags ) ) {
return parent::parseManualRule( $rule, $flags );
}
$carray = [];
// otherwise ignore all formatting
foreach ( $this->mVariants as $v ) {
$carray[$v] = $rule;
}
return $carray;
}
/**
* A function wrapper:
* - if there is no selected variant, leave the link

38
languages/classes/LanguageShi.php
View file

@ -72,44 +72,6 @@ class ShiConverter extends LanguageConverter {
];
}
/**
* rules should be defined as -{Tifinagh | Latin-} -or-
* -{code:text | code:text | ...}-
* update: delete all rule parsing because it's not used
* currently, and just produces a couple of bugs
*
* @param string $rule
* @param array $flags
* @return array
*/
function parseManualRule( $rule, $flags = [] ) {
if ( in_array( 'T', $flags ) ) {
return parent::parseManualRule( $rule, $flags );
}
$carray = [];
// otherwise ignore all formatting
foreach ( $this->mVariants as $v ) {
$carray[$v] = $rule;
}
return $carray;
}
/**
* Do not convert content on talk pages
*
* @param string $text
* @param Parser $parser
* @return string
*/
function parserConvert( $text, &$parser ) {
$this->mDoContentConvert = !( is_object( $parser->getTitle() )
&& $parser->getTitle()->isTalkPage() );
return parent::parserConvert( $text, $parser );
}
/**
* A function wrapper:
* - if there is no selected variant, leave the link

25
languages/classes/LanguageSr.php
View file

@ -75,31 +75,6 @@ class SrConverter extends LanguageConverter {
];
}
/**
* rules should be defined as -{ekavian | iyekavian-} -or-
* -{code:text | code:text | ...}-
*
* update: delete all rule parsing because it's not used
* currently, and just produces a couple of bugs
*
* @param string $rule
* @param array $flags
* @return array
*/
function parseManualRule( $rule, $flags = [] ) {
if ( in_array( 'T', $flags ) ) {
return parent::parseManualRule( $rule, $flags );
}
$carray = [];
// otherwise ignore all formatting
foreach ( $this->mVariants as $v ) {
$carray[$v] = $rule;
}
return $carray;
}
/**
* A function wrapper:
* - if there is no selected variant, leave the link

2
tests/phan/config.php
View file

@ -337,7 +337,7 @@ return [
"PhanUndeclaredMethod",
// approximate error count: 1342
"PhanUndeclaredProperty",
// approximate error count: 9
// approximate error count: 3
"PhanUndeclaredStaticMethod",
// approximate error count: 79
"PhanUndeclaredVariable",