Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Log logouts

Browse source 
Not terribly useful but we log all other auth events so why not.

Bug: T125184
Change-Id: I636f0eb5e1e9ffc49023941801c7c286410514d8
This commit is contained in:
Gergő Tisza 2016-02-12 13:47:31 -08:00 committed by Gergő Tisza
parent 1b4334c3a2
commit cb7d532818
1 changed files with 8 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
includes/user/User.php
View file

@ -3859,6 +3859,7 @@ class User implements IDBAccessObject {
if ( !$session->canSetUser() ) {
\MediaWiki\Logger\LoggerFactory::getInstance( 'session' )
->warning( __METHOD__ . ": Cannot log out of an immutable session" );
$error = 'immutable';
} elseif ( !$session->getUser()->equals( $this ) ) {
\MediaWiki\Logger\LoggerFactory::getInstance( 'session' )
->warning( __METHOD__ .
@ -3866,6 +3867,7 @@ class User implements IDBAccessObject {
);
// But we still may as well make this user object anon
$this->clearInstanceCache( 'defaults' );
$error = 'wronguser';
} else {
$this->clearInstanceCache( 'defaults' );
$delay = $session->delaySave();
@ -3874,7 +3876,13 @@ class User implements IDBAccessObject {
$session->setUser( new User );
$session->set( 'wsUserID', 0 ); // Other code expects this
ScopedCallback::consume( $delay );
$error = false;
}
\MediaWiki\Logger\LoggerFactory::getInstance( 'authmanager' )->info( 'Logout', [
'event' => 'logout',
'successful' => $error === false,
'status' => $error ?: 'success',
] );
}
/**