Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

CreditsAction: Minor code tweaks

Browse source 
Change-Id: Ie3bff75102e01ed6e174ee21541b598b746a99dd
This commit is contained in:
Reedy 2021-10-21 20:22:35 +01:00
parent c0f12afe1e
commit cf90246692
1 changed files with 7 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
includes/actions/CreditsAction.php
View file

@ -72,7 +72,7 @@ class CreditsAction extends FormlessAction {
'mediawiki.action.styles',
] );
if ( $this->getWikiPage()->getId() == 0 ) {
if ( $this->getWikiPage()->getId() === 0 ) {
$s = $this->msg( 'nocredits' )->parse();
} else {
$s = $this->getCredits( -1 );
@ -91,7 +91,7 @@ class CreditsAction extends FormlessAction {
public function getCredits( $cnt, $showIfMax = true ) {
$s = '';
if ( $cnt != 0 ) {
if ( $cnt !== 0 ) {
$s = $this->getAuthor();
if ( $cnt > 1 || $cnt < 0 ) {
$s .= ' ' . $this->getContributors( $cnt - 1, $showIfMax );
@ -174,7 +174,7 @@ class CreditsAction extends FormlessAction {
$anon_ips[] = $this->link( $user );
}
if ( $cnt == 0 ) {
if ( $cnt === 0 ) {
break;
}
}
@ -203,19 +203,19 @@ class CreditsAction extends FormlessAction {
}
# This is the big list, all mooshed together. We sift for blank strings
$fulllist = [];
$fullList = [];
foreach ( [ $real, $user, $anon, $others_link ] as $s ) {
if ( $s !== false ) {
array_push( $fulllist, $s );
$fullList[] = $s;
}
}
$count = count( $fulllist );
$count = count( $fullList );
# "Based on work by ..."
return $count
? $this->msg( 'othercontribs' )->rawParams(
$lang->listToText( $fulllist ) )->params( $count )->escaped()
$lang->listToText( $fullList ) )->params( $count )->escaped()
: '';
}