Drop the PersonalUrls hook, deprecated in 1.39

Bug: T319087
Change-Id: I398de94099cf17d071bc539a87a140a76fd301bd

RELEASE-NOTES-1.41

@@ -301,6 +301,7 @@ because of Phabricator reports.
   deprecation.
 * SkinTemplateNavigation and SkinTemplateNavigation::SpecialPage hooks,
   deprecated in 1.39, have been removed.
+* The PersonalUrls hook, deprecated in 1.39, has been removed.
 * OutputPage::getCSPNonce(), soft deprecated in 1.35, now emits deprecation
   warnings.
 * Support of the third parameter of LogEventsListGetExtraInputs hook,

autoload.php

@@ -1334,7 +1334,6 @@ $wgAutoloadLocalClasses = [
 	'MediaWiki\\Hook\\ParserTestGlobalsHook' => __DIR__ . '/includes/Hook/ParserTestGlobalsHook.php',
 	'MediaWiki\\Hook\\ParserTestTablesHook' => __DIR__ . '/includes/Hook/ParserTestTablesHook.php',
 	'MediaWiki\\Hook\\PasswordPoliciesForUserHook' => __DIR__ . '/includes/password/Hook/PasswordPoliciesForUserHook.php',
-	'MediaWiki\\Hook\\PersonalUrlsHook' => __DIR__ . '/includes/skins/Hook/PersonalUrlsHook.php',
 	'MediaWiki\\Hook\\PostLoginRedirectHook' => __DIR__ . '/includes/specials/Hook/PostLoginRedirectHook.php',
 	'MediaWiki\\Hook\\PreferencesGetIconHook' => __DIR__ . '/includes/Hook/PreferencesGetIconHook.php',
 	'MediaWiki\\Hook\\PreferencesGetLayoutHook' => __DIR__ . '/includes/Hook/PreferencesGetLayoutHook.php',

includes/HookContainer/DeprecatedHooks.php

@@ -47,7 +47,6 @@ class DeprecatedHooks {
 		'userCan' => [ 'deprecatedVersion' => '1.37' ],
 		'ArticleDelete' => [ 'deprecatedVersion' => '1.37', 'silent' => true ],
 		'ArticleDeleteComplete' => [ 'deprecatedVersion' => '1.37', 'silent' => true ],
-		'PersonalUrls' => [ 'deprecatedVersion' => '1.39' ],
 		'SearchDataForIndex' => [ 'deprecatedVersion' => '1.40', 'silent' => true ],
 		'ArticleUndelete' => [ 'deprecatedVersion' => '1.40', 'silent' => true ],
 		'MessageCache::get' => [ 'deprecatedVersion' => '1.41', 'silent' => true ],

includes/HookContainer/HookRunner.php

@@ -336,7 +336,6 @@ class HookRunner implements
 	\MediaWiki\Hook\SkinSubPageSubtitleHook,
 	\MediaWiki\Hook\SkinTemplateGetLanguageLinkHook,
 	\MediaWiki\Hook\SkinTemplateNavigation__UniversalHook,
-	\MediaWiki\Hook\PersonalUrlsHook,
 	\MediaWiki\Hook\SoftwareInfoHook,
 	\MediaWiki\Hook\SpecialBlockModifyFormFieldsHook,
 	\MediaWiki\Hook\SpecialContributionsBeforeMainOutputHook,
@@ -3074,14 +3073,6 @@ class HookRunner implements
 		);
 	}
 
-	public function onPersonalUrls( &$personal_urls, &$title, $skin ): void {
-		$this->container->run(
-			'PersonalUrls',
-			[ &$personal_urls, &$title, $skin ],
-			[ 'abortable' => false ]
-		);
-	}
-
 	public function onPingLimiter( $user, $action, &$result, $incrBy ) {
 		return $this->container->run(
 			'PingLimiter',

includes/skins/Hook/PersonalUrlsHook.php

@@ -1,31 +0,0 @@
-<?php
-
-namespace MediaWiki\Hook;
-
-use MediaWiki\Title\Title;
-use SkinTemplate;
-
-/**
- * This is a hook handler interface, see docs/Hooks.md.
- * Use the hook name "PersonalUrls" to register handlers implementing this interface.
- *
- * @stable to implement
- * @deprecated since 1.39 Use SkinTemplateNavigation__Universal instead.
- * @ingroup Hooks
- */
-interface PersonalUrlsHook {
-	/**
-	 * Use this hook to alter the user-specific navigation links (e.g. "my page,
-	 * my talk page, my contributions" etc).
-	 *
-	 * @since 1.35
-	 * @deprecated since 1.39 Use SkinTemplateNavigation__Universal instead.
-	 *
-	 * @param array &$personal_urls Array of link specifiers (see SkinTemplate.php)
-	 * @param Title &$title Current page
-	 * @param SkinTemplate $skin SkinTemplate object providing context (e.g. to check if the user is
-	 *   logged in, etc.)
-	 * @return void This hook must not abort, it must return no value
-	 */
-	public function onPersonalUrls( &$personal_urls, &$title, $skin ): void;
-}

includes/skins/SkinTemplate.php

@@ -523,8 +523,6 @@ class SkinTemplate extends Skin {
 			}
 		}
 
-		$this->getHookRunner()->onPersonalUrls( $personal_urls, $title, $this );
-
 		return $personal_urls;
 	}