Be consistent about 'TablePager' CSS class usage

* Do not use it when not actually using the TablePager
* Always use it when actually using the TablePager
* Use parent::getTableClass() rather than hardcoding it every time
* Place it before other classes to allow overriding

Change-Id: I042b65be64e2c2fa6c68a7bb972a7a2ea7f55b4e
This commit is contained in:
Bartosz Dziewoński 2014-08-23 15:00:07 +02:00
parent 7d04663398
commit d473b6d343
5 changed files with 8 additions and 7 deletions

View file

@ -336,8 +336,9 @@ class AllMessagesTablePager extends TablePager {
}
function getStartBody() {
$tableClass = $this->getTableClass();
return Xml::openElement( 'table', array(
'class' => 'mw-datatable TablePager',
'class' => "mw-datatable $tableClass",
'id' => 'mw-allmessagestable'
) ) .
"\n" .

View file

@ -409,7 +409,7 @@ class BlockListPager extends TablePager {
}
public function getTableClass() {
return 'TablePager mw-blocklist';
return parent::getTableClass() . ' mw-blocklist';
}
function getIndexField() {

View file

@ -557,15 +557,15 @@ class ImageListPager extends TablePager {
}
function getTableClass() {
return 'listfiles ' . parent::getTableClass();
return parent::getTableClass() . ' listfiles';
}
function getNavClass() {
return 'listfiles_nav ' . parent::getNavClass();
return parent::getNavClass() . ' listfiles_nav';
}
function getSortHeaderClass() {
return 'listfiles_sort ' . parent::getSortHeaderClass();
return parent::getSortHeaderClass() . ' listfiles_sort';
}
function getPagingQueries() {

View file

@ -558,7 +558,7 @@ class ProtectedPagesPager extends TablePager {
}
public function getTableClass() {
return 'TablePager mw-protectedpages';
return parent::getTableClass() . ' mw-protectedpages';
}
function getIndexField() {

View file

@ -41,7 +41,7 @@ class SpecialTrackingCategories extends SpecialPage {
$this->outputHeader();
$this->getOutput()->allowClickjacking();
$this->getOutput()->addHTML(
Html::openElement( 'table', array( 'class' => 'mw-datatable TablePager',
Html::openElement( 'table', array( 'class' => 'mw-datatable',
'id' => 'mw-trackingcategories-table' ) ) . "\n" .
"<thead><tr>
<th>" .