Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix 3 PHPCS warnings in ResourceLoaderImage.php

Browse source 
Change-Id: I2cadf8441ac28473e3c4d0bb122e74e3f6c031ed
This commit is contained in:
Siebrand Mazeland 2015-09-28 14:04:45 +02:00
parent 776aee43d2
commit d5392ece3c
1 changed files with 17 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

32
includes/resourceloader/ResourceLoaderImage.php
View file

@ -315,21 +315,23 @@ class ResourceLoaderImage {
* @return string|bool PNG image data, or false on failure
*/
protected function rasterize( $svg ) {
// This code should be factored out to a separate method on SvgHandler, or perhaps a separate
// class, with a separate set of configuration settings.
//
// This is a distinct use case from regular SVG rasterization:
// * We can skip many sanity and security checks (as the images come from a trusted source,
// rather than from the user).
// * We need to provide extra options to some converters to achieve acceptable quality for very
// small images, which might cause performance issues in the general case.
// * We want to directly pass image data to the converter, rather than a file path.
//
// See https://phabricator.wikimedia.org/T76473#801446 for examples of what happens with the
// default settings.
//
// For now, we special-case rsvg (used in WMF production) and do a messy workaround for other
// converters.
/**
* This code should be factored out to a separate method on SvgHandler, or perhaps a separate
* class, with a separate set of configuration settings.
*
* This is a distinct use case from regular SVG rasterization:
* * We can skip many sanity and security checks (as the images come from a trusted source,
* rather than from the user).
* * We need to provide extra options to some converters to achieve acceptable quality for very
* small images, which might cause performance issues in the general case.
* * We want to directly pass image data to the converter, rather than a file path.
*
* See https://phabricator.wikimedia.org/T76473#801446 for examples of what happens with the
* default settings.
*
* For now, we special-case rsvg (used in WMF production) and do a messy workaround for other
* converters.
*/
global $wgSVGConverter, $wgSVGConverterPath;