Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge "Request: Improve log message when headers already sent" into REL1_43

Browse source
This commit is contained in:
jenkins-bot 2025-03-10 19:31:32 +00:00 committed by Gerrit Code Review
commit d5837014b9
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
includes/Request/HeaderCallback.php
View file

@ -90,12 +90,12 @@ class HeaderCallback {
* @since 1.29
*/
public static function warnIfHeadersSent() {
if ( headers_sent() && !self::$messageSent ) {
if ( !self::$messageSent && headers_sent( $filename, $line ) ) {
self::$messageSent = true;
\MediaWiki\Debug\MWDebug::warning( 'Headers already sent, should send headers earlier than ' .
wfGetCaller( 3 ) );
$logger = \MediaWiki\Logger\LoggerFactory::getInstance( 'headers-sent' );
$logger->error( 'Warning: headers were already sent from the location below', [
$logger->error( 'Warning: headers were already sent (output started at ' . $filename . ':' . $line . ')', [
'exception' => self::$headersSentException,
'detection-trace' => new RuntimeException( 'Detected here' ),
] );