Exclude includes/PHPVersionCheck.php from phan scanning

Subset cherry pick of a patch from REL1_35
Change-Id: Ic179ae51e9508e4af8c1fe57b78daa6102534faa

.phan/config.php

@@ -85,6 +85,9 @@ $cfg['exclude_analysis_directory_list'] = [
 	'includes/libs/jsminplus.php',
 	// External class
 	'includes/libs/objectcache/utils/MemcachedClient.php',
+	// File may be valid, but may contain numerous "errors" such as iterating over an
+	// empty array due to the version checking in T246594 not being currently used.
+	'includes/PHPVersionCheck.php',
 ];
 
 // These are too spammy for now. TODO enable

includes/PHPVersionCheck.php

@@ -20,7 +20,6 @@
 
 // phpcs:disable Generic.Arrays.DisallowLongArraySyntax,PSR2.Classes.PropertyDeclaration,MediaWiki.Usage.DirUsage
 // phpcs:disable Squiz.Scope.MemberVarScope.Missing,Squiz.Scope.MethodScope.Missing
-// @phan-file-suppress PhanPluginDuplicateConditionalNullCoalescing
 /**
  * Check PHP Version, as well as for composer dependencies in entry points,
  * and display something vaguely comprehensible in the event of a totally
@@ -103,7 +102,6 @@ class PHPVersionCheck {
 		$versionString = "PHP $minimumVersion or higher";
 
 		// Left as a programmatic check to make it easier to update.
-		// @phan-suppress-next-line PhanRedundantCondition
 		if ( count( $knownBad ) ) {
 			$versionString .= ' (and not ' . implode( ', ', array_values( $knownBad ) ) . ')';