Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Remove deprecated skin methods 3

Browse source 
* getAllowedSkins()
 * makeVariablesScript()
 * getSkinNames()

Bug: T287776
Change-Id: I518cabdf11fb6c6d317ca70b58418ef683a8baaa
This commit is contained in:
Ammarpad 2021-09-23 08:09:57 +01:00 committed by jdlrobson
parent 292fa3ae54
commit d93f45b034
2 changed files with 2 additions and 48 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
RELEASE-NOTES-1.38
View file

@ -97,7 +97,8 @@ because of Phabricator reports.
interwiki title through by default, logging a deprecation warning.
* Several Skin methods, hard deprecated in 1.36, have been removed. These
include Skin::privacyLink(), aboutLink(), disclaimerLink(), makeUrl()
getIndicatorsHTML(), getLogo(), subPageSubtitle(), getSearchLink() and
getIndicatorsHTML(), getLogo(), subPageSubtitle(), getSearchLink(),
makeVariablesScript(), getAllowedSkins(), getSkinNames() and
mainPageLink().
* …

47
includes/skins/Skin.php
View file

@ -87,35 +87,6 @@ abstract class Skin extends ContextSource {
return self::VERSION_MAJOR;
}
/**
* Fetch the set of available skins.
*
* @deprecated since 1.36. Use SkinFactory::getInstalledSkins() instead.
* @return array Associative array of strings
*/
public static function getSkinNames() {
wfDeprecated( __METHOD__, '1.36' );
$skinFactory = MediaWikiServices::getInstance()->getSkinFactory();
return $skinFactory->getInstalledSkins();
}
/**
* Fetch the list of user-selectable skins in regards to $wgSkipSkins.
* Useful for Special:Preferences and other places where you
* only want to show skins users _can_ use.
*
* @since 1.23
* @deprecated since 1.36. Use SkinFactory::getAllowedSkins() instead.
* @return string[]
*/
public static function getAllowedSkins() {
wfDeprecated( __METHOD__, '1.36' );
$skinFactory = MediaWikiServices::getInstance()->getSkinFactory();
return $skinFactory->getAllowedSkins();
}
/**
* Normalize a skin preference value to a form that can be loaded.
*
@ -466,24 +437,6 @@ abstract class Skin extends ContextSource {
*/
abstract public function outputPage();
/**
* @deprecated since 1.36. Use ResourceLoader::makeInlineScript() directly.
* @param array $data
* @param string|null $nonce OutputPage->getCSP()->getNonce()
* @return string|WrappedString HTML
*/
public static function makeVariablesScript( $data, $nonce = null ) {
wfDeprecated( __METHOD__, '1.36' );
if ( $data ) {
return ResourceLoader::makeInlineScript(
ResourceLoader::makeConfigSetScript( $data ),
$nonce
);
}
return '';
}
/**
* TODO: document
* @param Title $title