Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Remove two unused constants from EditPage.php

Browse source 
Specifically constants AS_USER_CANNOT_EDIT and AS_OK

Change-Id: I96b20962b7d4cab5c026a0f03abf9da066fbd9af
This commit is contained in:
withoutaname 2014-07-21 17:50:47 -07:00
parent b8c038f678
commit da5090774f
2 changed files with 2 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
includes/EditPage.php
View file

@ -66,11 +66,6 @@ class EditPage {
*/
const AS_CONTENT_TOO_BIG = 216;
/**
* Status: User cannot edit? (not used)
*/
const AS_USER_CANNOT_EDIT = 217;
/**
* Status: this anonymous user is not allowed to edit this page
*/
@ -129,11 +124,6 @@ class EditPage {
*/
const AS_MAX_ARTICLE_SIZE_EXCEEDED = 229;
/**
* not used
*/
const AS_OK = 230;
/**
* Status: WikiPage::doEdit() was unsuccessful
*/

4
tests/phpunit/includes/EditPageTest.php
View file

@ -82,7 +82,7 @@ class EditPageTest extends MediaWikiLangTestCase {
* * wpMinorEdit: mark as minor edit
* * wpWatchthis: whether to watch the page
* @param int|null $expectedCode The expected result code (EditPage::AS_XXX constants).
* Set to null to skip the check. Defaults to EditPage::AS_OK.
* Set to null to skip the check.
* @param string|null $expectedText The text expected to be on the page after the edit.
* Set to null to skip the check.
* @param string|null $message An optional message to show along with any error message.
@ -90,7 +90,7 @@ class EditPageTest extends MediaWikiLangTestCase {
* @return WikiPage The page that was just edited, useful for getting the edit's rev_id, etc.
*/
protected function assertEdit( $title, $baseText, $user = null, array $edit,
$expectedCode = EditPage::AS_OK, $expectedText = null, $message = null
$expectedCode = null, $expectedText = null, $message = null
) {
if ( is_string( $title ) ) {
$ns = $this->getDefaultWikitextNS();