Suppress php 7.4 phan false positive

see T298571

This failure only shows up for php 7.4 since that is using
dbal 3.x.x while php 7.2 is using dbal 2.x.x

Phan analysis is being disabled for those files for php 7.2
since those are now failing with 'unused suppression' and
php 7.2 support is going to be dropped in the near future,
so that doesn't matter to much.

Bug: T316518
Change-Id: I74da37dc4329a7dd2c015a9d1fc7037a866f40c9

.phan/config.php

@@ -104,6 +104,18 @@ $cfg['exclude_analysis_directory_list'] = [
 	'includes/PHPVersionCheck.php',
 ];
 
+if ( version_compare( PHP_VERSION, '7.4.0', '<' ) ) {
+	$cfg['exclude_analysis_directory_list'] = array_merge(
+		$cfg['exclude_analysis_directory_list'],
+		[
+			'includes/libs/rdbms/dbal/MWMySQLPlatform.php',
+			'includes/libs/rdbms/dbal/MWMySQLPlatformCompat.php',
+			'includes/libs/rdbms/dbal/MWPostgreSqlPlatform.php',
+			'includes/libs/rdbms/dbal/MWPostgreSqlPlatformCompat.php',
+		]
+	);
+}
+
 // Do not use aliases in core.
 // Use the correct name, because we don't need backward compatibility
 $cfg['enable_class_alias_support'] = false;

includes/libs/rdbms/dbal/MWMySQLPlatform.php

@@ -2,6 +2,10 @@
 
 namespace Wikimedia\Rdbms;
 
+/**
+ * @phan-file-suppress PhanCommentAbstractOnInheritedMethod T298571
+ */
+
 /**
  * @suppress PhanRedefinedExtendedClass
  */

includes/libs/rdbms/dbal/MWMySQLPlatformCompat.php

@@ -1,5 +1,10 @@
 <?php
 // phpcs:ignoreFile -- This is a very temporary file
+
+/**
+ * @phan-file-suppress PhanCommentAbstractOnInheritedMethod T298571
+ */
+
 namespace Wikimedia\Rdbms;
 
 // T270740 - HACK: In doctrine/dbal 3.0.0, they renamed MySql -> MySQL

includes/libs/rdbms/dbal/MWPostgreSqlPlatform.php

@@ -1,5 +1,9 @@
 <?php
 
+/**
+ * @phan-file-suppress PhanCommentAbstractOnInheritedMethod T298571
+ */
+
 namespace Wikimedia\Rdbms;
 
 use Wikimedia\Timestamp\ConvertibleTimestamp;

includes/libs/rdbms/dbal/MWPostgreSqlPlatformCompat.php

@@ -1,5 +1,9 @@
 <?php
 
+/**
+ * @phan-file-suppress PhanCommentAbstractOnInheritedMethod T298571
+ */
+
 namespace Wikimedia\Rdbms;
 
 // T270740 - HACK