Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Reduced DB contention in User::saveOptions().

Browse source 
Change-Id: Ic91501cd6476dae54b54b85f2f06c25bd2577c9b
This commit is contained in:
Aaron Schulz 2013-04-16 12:43:04 -07:00 committed by Gerrit Code Review
parent 4b520e95c3
commit dc0fae6f6a
1 changed files with 12 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
includes/User.php
View file

@ -4428,8 +4428,18 @@ class User {
}
$dbw = wfGetDB( DB_MASTER );
$dbw->delete( 'user_properties', array( 'up_user' => $userId ), __METHOD__ );
$dbw->insert( 'user_properties', $insert_rows, __METHOD__ );
$hasRows = $dbw->selectField( 'user_properties', '1',
array( 'up_user' => $userId ), __METHOD__ );
if ( $hasRows ) {
// Only do this delete if there is something there. A very large portion of
// calls to this function are for setting 'rememberpassword' for new accounts.
// Doing this delete for new accounts with no rows in the table rougly causes
// gap locks on [max user ID,+infinity) which causes high contention since many
// updates will pile up on each other since they are for higher (newer) user IDs.
$dbw->delete( 'user_properties', array( 'up_user' => $userId ), __METHOD__ );
}
$dbw->insert( 'user_properties', $insert_rows, __METHOD__, array( 'IGNORE' ) );
}
/**