Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge "Cache some more repeated messages in changes lists"

Browse source
This commit is contained in:
jenkins-bot 2023-08-19 19:31:29 +00:00 committed by Gerrit Code Review
commit dc412f3bb5
4 changed files with 11 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
includes/actions/HistoryAction.php
View file

@ -96,7 +96,10 @@ class HistoryAction extends FormlessAction {
// Precache various messages
if ( !isset( $this->message ) ) {
$this->message = [];
$msgs = [ 'cur', 'tooltip-cur', 'last', 'tooltip-last', 'pipe-separator' ];
$msgs = [
'cur', 'tooltip-cur', 'last', 'tooltip-last', 'pipe-separator',
'changeslist-nocomment', 'updatedmarker',
];
foreach ( $msgs as $msg ) {
$this->message[$msg] = $this->msg( $msg )->escaped();
}

4
includes/actions/pagers/HistoryPager.php
View file

@ -455,12 +455,12 @@ class HistoryPager extends ReverseChronologicalPager {
$s2 = $this->formattedComments[$resultOffset];
if ( $s2 === '' ) {
$defaultComment = $this->msg( 'changeslist-nocomment' )->escaped();
$defaultComment = $this->historyPage->message['changeslist-nocomment'];
$s2 = "<span class=\"comment mw-comment-none\">$defaultComment</span>";
}
if ( $this->notificationTimestamp && $row->rev_timestamp >= $this->notificationTimestamp ) {
$s2 .= ' <span class="updatedmarker">' . $this->msg( 'updatedmarker' )->escaped() . '</span>';
$s2 .= ' <span class="updatedmarker">' . $this->historyPage->message['updatedmarker'] . '</span>';
$classes[] = 'mw-history-line-updated';
}

4
includes/changes/ChangesList.php
View file

@ -191,7 +191,7 @@ class ChangesList extends ContextSource {
$this->message = [];
foreach ( [
'cur', 'diff', 'hist', 'enhancedrc-history', 'last', 'blocklink', 'history',
'semicolon-separator', 'pipe-separator' ] as $msg
'semicolon-separator', 'pipe-separator', 'word-separator' ] as $msg
) {
$this->message[$msg] = $this->msg( $msg )->escaped();
}
@ -736,7 +736,7 @@ class ChangesList extends ContextSource {
. $formatter->getActionText()
. " $mark"
. $formatter->getComment()
. $this->msg( 'word-separator' )->escaped()
. $this->message['word-separator']
. $formatter->getActionLinks()
. Html::closeElement( 'span' );
}

5
includes/specials/pagers/ContribsPager.php
View file

@ -229,7 +229,8 @@ class ContribsPager extends RangeChronologicalPager {
'diff',
'hist',
'pipe-separator',
'uctop'
'uctop',
'changeslist-nocomment',
];
foreach ( $msgs as $msg ) {
@ -764,7 +765,7 @@ class ContribsPager extends RangeChronologicalPager {
$comment = $this->formattedComments[$row->rev_id];
if ( $comment === '' ) {
$defaultComment = $this->msg( 'changeslist-nocomment' )->escaped();
$defaultComment = $this->messages['changeslist-nocomment'];
$comment = "<span class=\"comment mw-comment-none\">$defaultComment</span>";
}