Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fixup a couple of uses of return values of functions that return void

Browse source 
Change-Id: I7c8f08c5b436cb3209fd98b9479a50abe223cccc
This commit is contained in:
Reedy 2012-12-09 03:16:14 +00:00
parent d9cd65c902
commit dd16606d7a
3 changed files with 5 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
includes/api/ApiQueryUsers.php
View file

@ -250,7 +250,7 @@ class ApiQueryUsers extends ApiQueryBase {
}
$done[] = $u;
}
return $result->setIndexedTagName_internal( array( 'query', $this->getModuleName() ), 'user' );
$result->setIndexedTagName_internal( array( 'query', $this->getModuleName() ), 'user' );
}
/**

4
includes/parser/LinkHolderArray.php
View file

@ -254,12 +254,12 @@ class LinkHolderArray {
* @todo FIXME: Update documentation. makeLinkObj() is deprecated.
* Replace <!--LINK--> link placeholders with actual links, in the buffer
* Placeholders created in Skin::makeLinkObj()
* Returns an array of link CSS classes, indexed by PDBK.
* @return array of link CSS classes, indexed by PDBK.
*/
function replace( &$text ) {
wfProfileIn( __METHOD__ );
$colours = $this->replaceInternal( $text );
$colours = $this->replaceInternal( $text ); // FIXME: replaceInternal doesn't return a value
$this->replaceInterwiki( $text );
wfProfileOut( __METHOD__ );

3
includes/specials/SpecialNewpages.php
View file

@ -140,7 +140,8 @@ class SpecialNewpages extends IncludableSpecialPage {
$feedType = $this->opts->getValue( 'feed' );
if( $feedType ) {
return $this->feed( $feedType );
$this->feed( $feedType );
return;
}
$allValues = $this->opts->getAllValues();