Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

DifferenceEngine: Move MW_DIFF_VERSION to class constant DIFF_VERSION

Browse source 
Deprecated the former. It's only used in 2 extensions (both active),
so we can probably get rid of this within a single release cycle.

Change-Id: I39bef62556f8f0625a5741d54f9f84d15b50610d
This commit is contained in:
Chad Horohoe 2016-07-20 14:10:02 -07:00 committed by Chad
parent c42d81ec23
commit e0d2d91ef8
1 changed files with 9 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
includes/diff/DifferenceEngine.php
View file

@ -21,12 +21,7 @@
* @ingroup DifferenceEngine
*/
/**
* Constant to indicate diff cache compatibility.
* Bump this when changing the diff formatting in a way that
* fixes important bugs or such to force cached diff views to
* clear.
*/
// Deprecated, use class constant instead
define( 'MW_DIFF_VERSION', '1.11a' );
/**
@ -34,6 +29,13 @@ define( 'MW_DIFF_VERSION', '1.11a' );
* @ingroup DifferenceEngine
*/
class DifferenceEngine extends ContextSource {
/**
* Constant to indicate diff cache compatibility.
* Bump this when changing the diff formatting in a way that
* fixes important bugs or such to force cached diff views to
* clear.
*/
const DIFF_VERSION = MW_DIFF_VERSION;
/** @var int */
public $mOldid;
@ -777,7 +779,7 @@ class DifferenceEngine extends ContextSource {
throw new MWException( 'mOldid and mNewid must be set to get diff cache key.' );
}
return wfMemcKey( 'diff', 'version', MW_DIFF_VERSION,
return wfMemcKey( 'diff', 'version', self::MW_DIFF_VERSION,
'oldid', $this->mOldid, 'newid', $this->mNewid );
}