Merge "Hard deprecate LinkCache::addGoodLinkObj"

RELEASE-NOTES-1.38

@@ -268,6 +268,7 @@ because of Phabricator reports.
      ::getArchivedRevisionRecord, ::getPreviousRevisionRecord and
      ::getLastRevisionId.
    - Use ArchivedRevisionLookup::hasArchivedRevisions instead of ::isDeleted.
+* LinkCache::addGoodLinkObj() has been hard deprecated.
 * …
 
 === Other changes in 1.38 ===

includes/cache/LinkCache.php

@@ -282,6 +282,7 @@ class LinkCache implements LoggerAwareInterface {
 	public function addGoodLinkObj( $id, $page, $len = -1, $redir = null,
 		$revision = 0, $model = null, $lang = null
 	) {
+		wfDeprecated( __METHOD__, '1.38' );
 		$this->addGoodLinkObjFromRow( $page, (object)[
 			'page_id' => (int)$id,
 			'page_namespace' => $page->getNamespace(),

tests/phpunit/includes/TitleTest.php

@@ -16,6 +16,7 @@ use Wikimedia\TestingAccessWrapper;
  */
 class TitleTest extends MediaWikiIntegrationTestCase {
 	use DummyServicesTrait;
+	use LinkCacheTestTrait;
 
 	protected function setUp(): void {
 		parent::setUp();
@@ -367,10 +368,10 @@ class TitleTest extends MediaWikiIntegrationTestCase {
 	 * @covers Title::clearCaches
 	 */
 	public function testClearCaches() {
-		$linkCache = MediaWikiServices::getInstance()->getLinkCache();
+		$linkCache = $this->getServiceContainer()->getLinkCache();
 
 		$title1 = Title::newFromText( 'Foo' );
-		$linkCache->addGoodLinkObj( 23, $title1 );
+		$this->addGoodLinkObject( 23, $title1 );
 
 		Title::clearCaches();