Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

dao: Correct return type doc for getLoadBalancer()

Browse source 
This method creates a load balancer object using services and calls
getMainLB() which returns an instance of ILoadBalancer and not an
instance of LoadBalancer, hence, getLoadBalancer() should return an
instance of ILoadBalancer instead.

Change-Id: I8859f293985d256d02ddc6f90e2aea813ebfc955
This commit is contained in:
Derick Alangi 2019-04-11 23:03:57 +01:00 committed by D3r1ck01
parent 5e45f7444f
commit e1f5364f56
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
includes/dao/DBAccessBase.php
View file

@ -2,7 +2,7 @@
use MediaWiki\MediaWikiServices;
use Wikimedia\Rdbms\IDatabase;
use Wikimedia\Rdbms\LoadBalancer;
use Wikimedia\Rdbms\ILoadBalancer;
/**
* Base class for objects that allow access to other wiki's databases using
@ -88,7 +88,7 @@ abstract class DBAccessBase implements IDBAccessObject {
*
* @since 1.21
*
* @return LoadBalancer The database load balancer object
* @return ILoadBalancer The database load balancer object
*/
public function getLoadBalancer() {
$lbFactory = MediaWikiServices::getInstance()->getDBLoadBalancerFactory();