Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Test for writes being prevented on replica connections.

Browse source 
Bug: T183265
Change-Id: I319efa418cf8a46985f6faa60096559efa15d267
This commit is contained in:
daniel 2017-12-20 19:37:13 +01:00
parent 08edb27f6c
commit e213462f7c
1 changed files with 37 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

43
tests/phpunit/includes/db/LoadBalancerTest.php
View file

@ -1,5 +1,7 @@
<?php <?php
use Wikimedia\Rdbms\DBError;
use Wikimedia\Rdbms\IDatabase;
use Wikimedia\Rdbms\LoadBalancer; use Wikimedia\Rdbms\LoadBalancer;
/** /**
@ -24,7 +26,7 @@ use Wikimedia\Rdbms\LoadBalancer;
* @file * @file
*/ */
class LoadBalancerTest extends MediaWikiTestCase { class LoadBalancerTest extends MediaWikiTestCase {
public function testLBSimpleServer() { public function testWithoutReplica() {
global $wgDBserver, $wgDBname, $wgDBuser, $wgDBpassword, $wgDBtype, $wgSQLiteDataDir; global $wgDBserver, $wgDBname, $wgDBuser, $wgDBpassword, $wgDBtype, $wgSQLiteDataDir;
$servers = [ $servers = [
@ -48,10 +50,11 @@ class LoadBalancerTest extends MediaWikiTestCase {
$dbw = $lb->getConnection( DB_MASTER ); $dbw = $lb->getConnection( DB_MASTER );
$this->assertTrue( $dbw->getLBInfo( 'master' ), 'master shows as master' ); $this->assertTrue( $dbw->getLBInfo( 'master' ), 'master shows as master' );
$this->assertTrue( $dbw->getFlag( $dbw::DBO_TRX ), "DBO_TRX set on master" ); $this->assertTrue( $dbw->getFlag( $dbw::DBO_TRX ), "DBO_TRX set on master" );
$this->assertWriteAllowed( $dbw );
$dbr = $lb->getConnection( DB_REPLICA ); $dbr = $lb->getConnection( DB_REPLICA );
$this->assertTrue( $dbr->getLBInfo( 'master' ), 'DB_REPLICA also gets the master' ); $this->assertTrue( $dbr->getLBInfo( 'master' ), 'DB_REPLICA also gets the master' );
$this->assertTrue( $dbw->getFlag( $dbw::DBO_TRX ), "DBO_TRX set on replica" ); $this->assertTrue( $dbr->getFlag( $dbw::DBO_TRX ), "DBO_TRX set on replica" );
$dbwAuto = $lb->getConnection( DB_MASTER, [], false, $lb::CONN_TRX_AUTO ); $dbwAuto = $lb->getConnection( DB_MASTER, [], false, $lb::CONN_TRX_AUTO );
$this->assertFalse( $dbwAuto->getFlag( $dbw::DBO_TRX ), "No DBO_TRX with CONN_TRX_AUTO" ); $this->assertFalse( $dbwAuto->getFlag( $dbw::DBO_TRX ), "No DBO_TRX with CONN_TRX_AUTO" );
@ -69,7 +72,7 @@ class LoadBalancerTest extends MediaWikiTestCase {
$lb->closeAll(); $lb->closeAll();
} }
public function testLBSimpleServers() { public function testWithReplica() {
global $wgDBserver, $wgDBname, $wgDBuser, $wgDBpassword, $wgDBtype, $wgSQLiteDataDir; global $wgDBserver, $wgDBname, $wgDBuser, $wgDBpassword, $wgDBtype, $wgSQLiteDataDir;
$servers = [ $servers = [
@ -83,7 +86,7 @@ class LoadBalancerTest extends MediaWikiTestCase {
'load' => 0, 'load' => 0,
'flags' => DBO_TRX // REPEATABLE-READ for consistency 'flags' => DBO_TRX // REPEATABLE-READ for consistency
], ],
[ // emulated slave [ // emulated replica
'host' => $wgDBserver, 'host' => $wgDBserver,
'dbname' => $wgDBname, 'dbname' => $wgDBname,
'user' => $wgDBuser, 'user' => $wgDBuser,
@ -108,14 +111,16 @@ class LoadBalancerTest extends MediaWikiTestCase {
$dbw->getLBInfo( 'clusterMasterHost' ), $dbw->getLBInfo( 'clusterMasterHost' ),
'cluster master set' ); 'cluster master set' );
$this->assertTrue( $dbw->getFlag( $dbw::DBO_TRX ), "DBO_TRX set on master" ); $this->assertTrue( $dbw->getFlag( $dbw::DBO_TRX ), "DBO_TRX set on master" );
$this->assertWriteAllowed( $dbw );
$dbr = $lb->getConnection( DB_REPLICA ); $dbr = $lb->getConnection( DB_REPLICA );
$this->assertTrue( $dbr->getLBInfo( 'replica' ), 'slave shows as slave' ); $this->assertTrue( $dbr->getLBInfo( 'replica' ), 'replica shows as replica' );
$this->assertEquals( $this->assertEquals(
( $wgDBserver != '' ) ? $wgDBserver : 'localhost', ( $wgDBserver != '' ) ? $wgDBserver : 'localhost',
$dbr->getLBInfo( 'clusterMasterHost' ), $dbr->getLBInfo( 'clusterMasterHost' ),
'cluster master set' ); 'cluster master set' );
$this->assertTrue( $dbw->getFlag( $dbw::DBO_TRX ), "DBO_TRX set on replica" ); $this->assertTrue( $dbr->getFlag( $dbw::DBO_TRX ), "DBO_TRX set on replica" );
$this->assertWriteForbidden( $dbr );
$dbwAuto = $lb->getConnection( DB_MASTER, [], false, $lb::CONN_TRX_AUTO ); $dbwAuto = $lb->getConnection( DB_MASTER, [], false, $lb::CONN_TRX_AUTO );
$this->assertFalse( $dbwAuto->getFlag( $dbw::DBO_TRX ), "No DBO_TRX with CONN_TRX_AUTO" ); $this->assertFalse( $dbwAuto->getFlag( $dbw::DBO_TRX ), "No DBO_TRX with CONN_TRX_AUTO" );
@ -132,4 +137,30 @@ class LoadBalancerTest extends MediaWikiTestCase {
$lb->closeAll(); $lb->closeAll();
} }
private function assertWriteForbidden( IDatabase $db ) {
try {
$db->delete( 'user', [ 'user_id' => 57634126 ], 'TEST' );
$this->fail( 'Write operation should have failed!' );
} catch ( DBError $ex ) {
// check that the exception message contains "Write operation"
$constriant = new PHPUnit_Framework_Constraint_StringContains( 'Write operation' );
if ( !$constriant->evaluate( $ex->getMessage(), '', true ) ) {
// re-throw original error, to preserve stack trace
throw $ex;
}
} finally {
$db->rollback( __METHOD__, 'flush' );
}
}
private function assertWriteAllowed( IDatabase $db ) {
try {
$this->assertNotSame( false, $db->delete( 'user', [ 'user_id' => 57634126 ] ) );
} finally {
$db->rollback( __METHOD__, 'flush' );
}
}
} }