Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

resourceloader: Use makeComment() in tryRespondFromFileCache() for safety

Browse source 
Other code paths in this class already make use of this method,
but this was still embedding arbitrary strings directly, at the
risk of producting invalid CSS or invalid JavaScript.

Change-Id: Ied6c420536a3dd1ef8f3816a078705136e8475b1
This commit is contained in:
Timo Tijhof 2015-05-12 01:50:28 +01:00
parent 612e5f1137
commit e221d194c4
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
includes/resourceloader/ResourceLoader.php
View file

@ -808,7 +808,7 @@ class ResourceLoader {
// Capture any PHP warnings from the output buffer and append them to the
// response in a comment if we're in debug mode.
if ( $context->getDebug() && strlen( $warnings = ob_get_contents() ) ) {
$response = "/*\n$warnings\n*/\n" . $response;
$response = self::makeComment( $warnings ) . $response;
}
// Send content type and cache headers
$this->sendResponseHeaders( $context, $ts, false );