Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix space after comma in single-line array declaration

Browse source 
We are introducing a new phpcs sniff to make sure this doesn't happen

That sniff found this so far.

Bug: T342297
Change-Id: Ibce3f3d28e7d2cb5b0ff7230f584e76446965ddc
This commit is contained in:
Amir Sarabadani 2023-07-24 18:59:29 +02:00
parent 23f6dedbda
commit e33818cd08
7 changed files with 12 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
includes/deferred/UserEditCountUpdate.php
View file

@ -78,7 +78,7 @@ class UserEditCountUpdate implements DeferrableUpdate, MergeableUpdate {
$dbw->newUpdateQueryBuilder()
->update( 'user' )
->set( [ 'user_editcount=user_editcount+' . (int)$info->getIncrement() ] )
->where( [ 'user_id' => $userId,'user_editcount IS NOT NULL' ] )
->where( [ 'user_id' => $userId, 'user_editcount IS NOT NULL' ] )
->caller( $fname )->execute();
// Lazy initialization check...
if ( $dbw->affectedRows() == 0 ) {

10
includes/installer/PostgresUpdater.php
View file

@ -213,7 +213,7 @@ class PostgresUpdater extends DatabaseUpdater {
[ 'dropFkey', 'page_props', 'pp_page' ],
// page_props primary key change moved from the Schema SQL file to here in 1.36
[ 'changePrimaryKey', 'page_props', [ 'pp_page', 'pp_propname' ], 'page_props_pk' ],
[ 'setDefault','job', 'job_cmd', '' ],
[ 'setDefault', 'job', 'job_cmd', '' ],
[ 'changeField', 'job', 'job_namespace', 'INTEGER', '' ],
[ 'dropPgIndex', 'job', 'job_cmd_namespace_title' ],
[ 'addPgIndex', 'job', 'job_cmd', '(job_cmd, job_namespace, job_title, job_params)' ],
@ -225,10 +225,10 @@ class PostgresUpdater extends DatabaseUpdater {
[ 'renameIndex', 'page', 'page_unique_name', 'page_name_title' ],
[ 'addPGIndex', 'page', 'page_redirect_namespace_len', '(page_is_redirect, page_namespace, page_len)' ],
[ 'dropFkey', 'categorylinks', 'cl_from' ],
[ 'setDefault','categorylinks', 'cl_from', 0 ],
[ 'setDefault','categorylinks', 'cl_to', '' ],
[ 'setDefault','categorylinks', 'cl_sortkey', '' ],
[ 'setDefault','categorylinks', 'cl_collation', '' ],
[ 'setDefault', 'categorylinks', 'cl_from', 0 ],
[ 'setDefault', 'categorylinks', 'cl_to', '' ],
[ 'setDefault', 'categorylinks', 'cl_sortkey', '' ],
[ 'setDefault', 'categorylinks', 'cl_collation', '' ],
[ 'changeNullableField', 'categorylinks', 'cl_sortkey', 'NOT NULL', true ],
[ 'addIndex', 'categorylinks', 'categorylinks_pkey', 'patch-categorylinks-pk.sql' ],
[ 'addPgIndex', 'categorylinks', 'cl_timestamp', '(cl_to, cl_timestamp)' ],

2
maintenance/cleanupInvalidDbKeys.php
View file

@ -143,7 +143,7 @@ TEXT
$joinConds = [];
$tables = [ $table ];
if ( isset( $linksMigration::$mapping[$table] ) ) {
[ $nsField,$titleField ] = $linksMigration->getTitleFields( $table );
[ $nsField, $titleField ] = $linksMigration->getTitleFields( $table );
$joinConds = $linksMigration->getQueryInfo( $table )['joins'];
$tables = $linksMigration->getQueryInfo( $table )['tables'];
}

4
tests/phpunit/includes/WikiMapTest.php
View file

@ -284,8 +284,8 @@ class WikiMapTest extends MediaWikiLangTestCase {
public static function provideIsCurrentWikiId() {
return [
[ 'db', 'db', null, '' ],
[ 'db-schema-','db', 'schema', '' ],
[ 'db','db', 'mediawiki', '' ], // common b/c case
[ 'db-schema-', 'db', 'schema', '' ],
[ 'db', 'db', 'mediawiki', '' ], // common b/c case
[ 'db-prefix_', 'db', null, 'prefix_' ],
[ 'db-schema-prefix_', 'db', 'schema', 'prefix_' ],
[ 'db-prefix_', 'db', 'mediawiki', 'prefix_' ], // common b/c case

2
tests/phpunit/includes/language/LanguageConverterFactoryTest.php
View file

@ -523,6 +523,6 @@ class LanguageConverterFactoryTest extends MediaWikiLangTestCase {
'zh-sg' => 'zh-sg',
'zh-tw' => 'zh-tw'
];
yield 'zh' => [ 'zh', 'zh', ZhConverter::class, $zh_variants, $zh_variantfallbacks,[], $zh_flags, $zh_ml ];
yield 'zh' => [ 'zh', 'zh', ZhConverter::class, $zh_variants, $zh_variantfallbacks, [], $zh_flags, $zh_ml ];
}
}

2
tests/phpunit/includes/linker/LinkTargetStoreTest.php
View file

@ -27,7 +27,7 @@ class LinkTargetStoreTest extends MediaWikiIntegrationTestCase {
$db = $this->getServiceContainer()->getDBLoadBalancer()->getConnection( DB_PRIMARY );
$id = $linkTargetStore->acquireLinkTargetId( $target, $db );
$row = $db->newSelectQueryBuilder()
->select( [ 'lt_id','lt_namespace','lt_title' ] )
->select( [ 'lt_id', 'lt_namespace', 'lt_title' ] )
->from( 'linktarget' )
->where( [ 'lt_namespace' => $target->getNamespace(), 'lt_title' => $target->getDBkey() ] )
->fetchRow();

2
tests/phpunit/includes/user/BotPasswordTest.php
View file

@ -65,7 +65,7 @@ class BotPasswordTest extends MediaWikiIntegrationTestCase {
$dbw = wfGetDB( DB_PRIMARY );
$dbw->newDeleteQueryBuilder()
->delete( 'bot_passwords' )
->where( [ 'bp_user' => [ 42,43 ], 'bp_app_id' => 'BotPassword' ] )
->where( [ 'bp_user' => [ 42, 43 ], 'bp_app_id' => 'BotPassword' ] )
->caller( __METHOD__ )->execute();
$dbw->insert(
'bot_passwords',