Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Use TempFSFile in UploadFromUrl

Browse source 
Make it a little harder for the developer to leak files in the temp
directory by managing the temporary file with a TempFSFile instance.

Change-Id: I8bafc3a6e6212781d9e2e4f8f370ce7c446f1fd5
This commit is contained in:
Bryan Davis 2013-12-12 16:10:14 -07:00
parent 8d485c8309
commit e4009c7367
1 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
includes/upload/UploadFromUrl.php
View file

@ -204,13 +204,16 @@ class UploadFromUrl extends UploadBase {
}
return Status::newGood();
}
/**
* Create a new temporary file in the URL subdirectory of wfTempDir().
*
* @return string Path to the file
*/
protected function makeTemporaryFile() {
return tempnam( wfTempDir(), 'URL' );
$tmpFile = new TempFSFile( 'URL' );
$tmpFile->bind( $this );
return $tmpFile->getPath();
}
/**