Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

RecentChange: Drop getEngine(), deprecated since 1.29

Browse source 
Change-Id: Iad19dc62c4a06ccdb553ed11b3390679c761e17e
This commit is contained in:
James D. Forrester 2023-08-23 16:53:17 -04:00
parent f28d147474
commit e7ff62ea22
2 changed files with 2 additions and 25 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
RELEASE-NOTES-1.41
View file

@ -349,6 +349,8 @@ because of Phabricator reports.
* Not specifying a manifest_version in your extension.json or skin.json file,
deprecated since 1.26 and emitting warnings since 1.29, is no longer supported
with a fallback; it will now have unspecified behaviour.
* RecentChange::getEngine(), deprecated since 1.29, has been removed. Use
RCFeed::factory() instead.
* Passing a second query parameter to Title::getFullURL(), Title::getLocalURL(),
Title::getInternalURL(), or Title::getCanonicalURL(), each deprecated in 1.19,
is now not supported. Pass it as a key,value pair in the first parameter array

25
includes/changes/RecentChange.php
View file

@ -587,31 +587,6 @@ class RecentChange implements Taggable {
}
}
/**
* @since 1.22
* @codeCoverageIgnore
* @deprecated since 1.29 Use RCFeed::factory() instead. Hard deprecated since 1.38.
* @param string $uri URI to get the engine object for
* @param array $params
* @return FormattedRCFeed
*/
public static function getEngine( $uri, $params = [] ) {
wfDeprecated( __METHOD__, '1.29' );
$rcEngines =
MediaWikiServices::getInstance()->getMainConfig()->get( MainConfigNames::RCEngines );
$scheme = parse_url( $uri, PHP_URL_SCHEME );
if ( !$scheme ) {
throw new InvalidArgumentException( "Invalid RCFeed uri: '$uri'" );
}
if ( !isset( $rcEngines[$scheme] ) ) {
throw new InvalidArgumentException( "Unknown RCFeed engine: '$scheme'" );
}
if ( defined( 'MW_PHPUNIT_TEST' ) && is_object( $rcEngines[$scheme] ) ) {
return $rcEngines[$scheme];
}
return new $rcEngines[$scheme]( $params );
}
/**
* Mark this RecentChange as patrolled
*