Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

SettingsBuilder: add comments about batched caching.

Browse source 
One reason to have batching in SettingsBuilder is so we can cache an
entire batch of settings after merging them, rather than caching each
file individually. However, this has not been implemented, and it's not
entirely clear if it's a good idea. This patch adds comments to
SettingsBuilder that point to the relevant ticket, for reference
and consideration when working on SettingsBuilder in the future.

Bug: T304493
Change-Id: I1fb7b7e4a97e6d0788c9b1732a1718f3c8b365d5
This commit is contained in:
daniel 2022-03-23 11:38:31 +01:00 committed by BPirkle
parent 24dda0fb49
commit ea4d6422e3
1 changed files with 3 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
includes/Settings/SettingsBuilder.php
View file

@ -106,6 +106,7 @@ class SettingsBuilder {
public function load( SettingsSource $source ): self {
$this->assertNotFinished();
// XXX: We may want to cache the entire batch instead, see T304493.
$this->currentBatch[] = $this->wrapSource( $source );
return $this;
@ -204,6 +205,8 @@ class SettingsBuilder {
$this->assertNotFinished();
$this->config = null;
// XXX: We may want to cache the entire batch after merging together
// settings from all sources, see T304493.
$allSettings = $this->loadRecursive( $this->currentBatch );
foreach ( $allSettings as $settings ) {