Disable hooks display in Special:Version by default. It's unnecessarily technical, usually useless, and may cause unintended leakage of information about anti-spam measures in use.

This commit is contained in:
Tim Starling 2008-06-04 01:57:32 +00:00
parent 1daa0dc318
commit ea616bd180
3 changed files with 14 additions and 5 deletions

View file

@ -47,6 +47,8 @@ it from source control: http://www.mediawiki.org/wiki/Download_from_SVN
image page already exists
* $wgMaximumMovedPages restricts the number of pages that can be moved at once
(default 100) with the new subpage-move functionality of Special:Movepage
* Hooks display in Special:Version is now disabled by default, use
$wgSpecialVersionShowHooks = true; to enable it.
=== New features in 1.13 ===

View file

@ -948,6 +948,11 @@ $wgDebugDumpSql = false;
*/
$wgDebugLogGroups = array();
/**
* Show the contents of $wgHooks in Special:Version
*/
$wgSpecialVersionShowHooks = false;
/**
* Whether to show "we're sorry, but there has been a database error" pages.
* Displaying errors aids in debugging, but may display information useful

View file

@ -28,16 +28,18 @@ class SpecialVersion {
* main()
*/
function execute() {
global $wgOut, $wgMessageCache;
global $wgOut, $wgMessageCache, $wgSpecialVersionShowHooks;
$wgMessageCache->loadAllMessages();
$wgOut->addHTML( '<div dir="ltr">' );
$wgOut->addWikiText(
$text =
$this->MediaWikiCredits() .
$this->softwareInformation() .
$this->extensionCredits() .
$this->wgHooks()
);
$this->extensionCredits();
if ( $wgSpecialVersionShowHooks ) {
$text .= $this->wgHooks();
}
$wgOut->addWikiText( $text );
$wgOut->addHTML( $this->IPInfo() );
$wgOut->addHTML( '</div>' );
}