Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

TalkPageNotificationManager: Undeprecate passing null to setUserHasNewMessages

Browse source 
See: T239640#6130351

Bug: T239640
Change-Id: I27222d21383455f81f292a88f19da88a699275cf
This commit is contained in:
Clara Andrew-Wani 2020-05-14 15:19:52 -04:00
parent 1205a64850
commit ebcfc952ad
2 changed files with 8 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
includes/user/TalkPageNotificationManager.php
View file

@ -98,7 +98,8 @@ class TalkPageNotificationManager {
*
* @param UserIdentity $user
* @param RevisionRecord|null $curRev New, as yet unseen revision of the user talk page.
* Passing null is deprecated since 1.35
* Null is acceptable in case the revision is not known. This will indicate that new messages
* exist, but will not affect the latest seen message timestamp
*/
public function setUserHasNewMessages(
UserIdentity $user,

6
tests/phpunit/includes/user/TalkPageNotificationManagerTest.php
View file

@ -68,6 +68,12 @@ class TalkPageNotificationManagerTest extends MediaWikiIntegrationTestCase {
$manager->clearInstanceCache( $user );
$this->assertFalse( $manager->userHasNewMessages( $user ),
'Should be false after cache cleared' );
$manager->setUserHasNewMessages( $user, null );
$this->assertTrue( $manager->userHasNewMessages( $user ),
'Should be true after updated' );
$manager->removeUserHasNewMessages( $user );
$this->assertFalse( $manager->userHasNewMessages( $user ),
'Should be false after updated' );
}
/**