Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

MWDebug:detectDeprecatedOverride - soft deprecate if no version

Browse source 
We need a way to actually just detect the deprecation override,
without instantly emitting the deprecation warning. Providing
'false' to the method as a $version parameter seems like a logical
thing to use for it.

Change-Id: I7733846613f37a4ba168e944bc671b43264aa498
This commit is contained in:
Petr Pchelko 2021-07-30 06:46:00 -07:00
parent 4aea1a348d
commit ed1a1bbbdd
1 changed files with 2 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
includes/debug/MWDebug.php
View file

@ -241,6 +241,7 @@ class MWDebug {
* @param string $class Class declaring the deprecated method (typically __CLASS__ )
* @param string $method The name of the deprecated method.
* @param string|false $version Version in which the method was deprecated.
* Does not issue deprecation warnings if false.
* @param string|bool $component Component to which the class belongs.
* If false, it is assumed the class is in MediaWiki core.
* @param int $callerOffset How far up the callstack is the original
@ -265,10 +266,8 @@ class MWDebug {
if ( $version ) {
$component = $component ?: 'MediaWiki';
$msg = "$declaringClass overrides $method which was deprecated in $component $version.";
} else {
$msg = "$declaringClass overrides $method which is deprecated.";
self::deprecatedMsg( $msg, $version, $component, $callerOffset + 1 );
}
self::deprecatedMsg( $msg, $version, $component, $callerOffset + 1 );
return true;
}