Merge "Remove the ResourceLoaderSkinModule legacy feature stylesheet"
This commit is contained in:
jenkins-bot
Gerrit Code Review
commit
f098becfdc
4 changed files with 10 additions and 285 deletions
|
|
@ -82,6 +82,9 @@ because of Phabricator reports.
|
|||
- ::freeResult()
|
||||
* Database::wasKnownStatementRollbackError() was removed. Subclasses should
|
||||
override isKnownStatementRollbackError() instead.
|
||||
* Changes to skins:
|
||||
- The feature `legacy` used inside ResourceLoaderSkinModule,
|
||||
deprecated in 1.37, will no longer ship any styles.
|
||||
* …
|
||||
|
||||
=== Deprecations in 1.39 ===
|
||||
|
|
|
|||
|
|
@ -102,12 +102,6 @@ class ResourceLoaderSkinModule extends ResourceLoaderLessVarFileModule {
|
|||
* "i18n-headings":
|
||||
* Styles for line-heights of headings across different languages.
|
||||
*
|
||||
* "legacy":
|
||||
* For backwards compatibility a legacy feature is provided.
|
||||
* New skins should not use this if they can avoid doing so.
|
||||
* This feature also contains `interface-message-box` and
|
||||
* all `i18n-` prefixed features.
|
||||
*
|
||||
* "toc"
|
||||
* Styling rules for the table of contents.
|
||||
*
|
||||
|
|
@ -157,11 +151,9 @@ class ResourceLoaderSkinModule extends ResourceLoaderLessVarFileModule {
|
|||
'screen' => [ 'resources/src/mediawiki.skinning/elements.less' ],
|
||||
'print' => [ 'resources/src/mediawiki.skinning/elements-print.less' ],
|
||||
],
|
||||
'legacy' => [
|
||||
'all' => [ 'resources/src/mediawiki.skinning/messageBoxes.less' ],
|
||||
'print' => [ 'resources/src/mediawiki.skinning/commonPrint.less' ],
|
||||
'screen' => [ 'resources/src/mediawiki.skinning/legacy.less' ],
|
||||
],
|
||||
// The styles of the legacy feature was removed in 1.39. This can be removed when no skins are referencing it
|
||||
// (Dropping this line will trigger InvalidArgumentException: Feature 'legacy' is not recognised)
|
||||
'legacy' => [],
|
||||
'i18n-ordered-lists' => [
|
||||
'screen' => [ 'resources/src/mediawiki.skinning/i18n-ordered-lists.less' ],
|
||||
],
|
||||
|
|
@ -197,13 +189,12 @@ class ResourceLoaderSkinModule extends ResourceLoaderLessVarFileModule {
|
|||
* Default for when the 'features' parameter is absent.
|
||||
*
|
||||
* For backward-compatibility, when the parameter is not declared
|
||||
* only 'logo' and 'legacy' styles are loaded.
|
||||
* only 'logo' styles are loaded.
|
||||
*
|
||||
* @var string[]
|
||||
*/
|
||||
private const DEFAULT_FEATURES_ABSENT = [
|
||||
'logo',
|
||||
'legacy',
|
||||
];
|
||||
|
||||
private const LESS_MESSAGES = [
|
||||
|
|
@ -308,10 +299,11 @@ class ResourceLoaderSkinModule extends ResourceLoaderLessVarFileModule {
|
|||
$features[ 'content-links-external' ] = $features[ 'content-links' ];
|
||||
}
|
||||
|
||||
// The legacy feature is deprecated (T89981).
|
||||
// The legacy feature no longer exists (T89981) but to avoid fatals in skins is retained.
|
||||
if ( isset( $features['legacy'] ) && $features['legacy'] ) {
|
||||
$messages .= '[1.37] The use of the `legacy` feature with ResourceLoaderSkinModule is deprecated'
|
||||
. '(T89981). ';
|
||||
. '(T89981) and is a NOOP since 1.39 (T304325). This should be urgently omited to retain compatibility '
|
||||
. 'with future MediaWiki versions';
|
||||
}
|
||||
|
||||
// The `content-links` feature was split out from `elements`.
|
||||
|
|
|
|||
|
|
@ -1,42 +0,0 @@
|
|||
/* stylelint-disable selector-class-pattern */
|
||||
|
||||
/**
|
||||
* NOTE: This file is exclusively used by the legacy stylesheet, deprecated in 1.37
|
||||
* It is frozen, please don't add to it further.
|
||||
*/
|
||||
|
||||
/* @noflip */ div.tright,
|
||||
div.floatright,
|
||||
table.floatright {
|
||||
clear: right;
|
||||
float: right;
|
||||
}
|
||||
|
||||
/* @noflip */ div.tleft,
|
||||
div.floatleft,
|
||||
table.floatleft {
|
||||
float: left;
|
||||
clear: left;
|
||||
}
|
||||
|
||||
/* Directionality-specific styles for thumbnails - their positioning depends on content language */
|
||||
|
||||
/* @noflip */
|
||||
.mw-content-ltr .thumbcaption {
|
||||
text-align: left;
|
||||
}
|
||||
|
||||
/* @noflip */
|
||||
.mw-content-ltr .magnify {
|
||||
float: right;
|
||||
}
|
||||
|
||||
/* @noflip */
|
||||
.mw-content-rtl .thumbcaption {
|
||||
text-align: right;
|
||||
}
|
||||
|
||||
/* @noflip */
|
||||
.mw-content-rtl .magnify {
|
||||
float: left;
|
||||
}
|
||||
|
|
@ -1,228 +0,0 @@
|
|||
/**
|
||||
* CSS in this file is used by *all* skins (that have any CSS at all). Be
|
||||
* careful what you put in here, since what looks good in one skin may not in
|
||||
* another, but don't ignore the poor pre-Monobook users either.
|
||||
*
|
||||
* NOTE: The images which are referenced in this file are no longer in use in
|
||||
* essential interface components. They should NOT be embedded, because that
|
||||
* optimizes for the uncommon case at the cost of bloating the size of render-
|
||||
* blocking CSS common to all pages.
|
||||
*/
|
||||
@import 'mediawiki.mixins';
|
||||
|
||||
/* stylelint-disable selector-class-pattern */
|
||||
|
||||
/* GENERAL CLASSES FOR DIRECTIONALITY SUPPORT */
|
||||
|
||||
/**
|
||||
* These classes should be used for text depending on the content direction.
|
||||
* Content stuff like editsection, ul/ol and TOC depend on this.
|
||||
*/
|
||||
.mw-content-ltr {
|
||||
/* @noflip */
|
||||
direction: ltr;
|
||||
}
|
||||
|
||||
.mw-content-rtl {
|
||||
/* @noflip */
|
||||
direction: rtl;
|
||||
}
|
||||
|
||||
/* Most input fields should be in site direction */
|
||||
textarea,
|
||||
input {
|
||||
// Doubling of `dir` attribute selector increases specificity to allow
|
||||
// attributes to override content and/or site directionality. See T260993.
|
||||
.sitedir-ltr &,
|
||||
&[ dir='ltr' ][ dir='ltr' ] {
|
||||
/* @noflip */
|
||||
direction: ltr;
|
||||
}
|
||||
|
||||
.sitedir-rtl &,
|
||||
&[ dir='rtl' ][ dir='rtl' ] {
|
||||
/* @noflip */
|
||||
direction: rtl;
|
||||
}
|
||||
}
|
||||
|
||||
.mw-userlink {
|
||||
// Word-break overlong user names, see T237230.
|
||||
// FIXME: This property is introduced now, but will be separated in a follow-up
|
||||
// caring about 'i18n-directionality', see T247033.
|
||||
.hyphens( auto );
|
||||
unicode-bidi: embed;
|
||||
}
|
||||
|
||||
/* User-Agent styles for new HTML5 elements */
|
||||
mark {
|
||||
background-color: #ff0;
|
||||
color: #000;
|
||||
}
|
||||
|
||||
/* Helper for wbr element on IE 8+; in HTML5, but not supported by default as of IE 11. */
|
||||
/* Note canonical HTML5 styles recommend "content: \u200B", but this doesn't work as of IE 11. */
|
||||
wbr {
|
||||
display: inline-block;
|
||||
}
|
||||
|
||||
/* Input types that should follow user direction, like buttons */
|
||||
/* TODO: What about buttons in wikipage content ? */
|
||||
input[ type='submit' ],
|
||||
input[ type='button' ],
|
||||
input[ type='reset' ],
|
||||
input[ type='file' ] {
|
||||
direction: ltr;
|
||||
}
|
||||
|
||||
/* Default style for semantic tags */
|
||||
abbr[ title ], /* Note: Duplicate ruleset if skins load `normalize` and `legacy`. */
|
||||
.explain[ title ] {
|
||||
border-bottom: 1px dotted;
|
||||
cursor: help;
|
||||
}
|
||||
|
||||
/* stylelint-disable-next-line plugin/no-unsupported-browser-features */
|
||||
@supports ( text-decoration: underline dotted ) {
|
||||
abbr[ title ], /* FIXME: Remove similar to `abbr` above. */
|
||||
.explain[ title ] {
|
||||
border-bottom: 0;
|
||||
text-decoration: underline dotted;
|
||||
}
|
||||
}
|
||||
|
||||
/* Comment portions of RC entries */
|
||||
span.comment {
|
||||
font-style: italic;
|
||||
unicode-bidi: -moz-isolate;
|
||||
unicode-bidi: isolate;
|
||||
}
|
||||
|
||||
/**
|
||||
* rev_deleted stuff
|
||||
*/
|
||||
li span.deleted,
|
||||
span.history-deleted {
|
||||
text-decoration: line-through;
|
||||
color: #72777d;
|
||||
font-style: italic;
|
||||
}
|
||||
|
||||
/**
|
||||
* Patrol stuff
|
||||
*/
|
||||
|
||||
/**
|
||||
* Forms
|
||||
*/
|
||||
td.mw-label {
|
||||
text-align: right;
|
||||
vertical-align: middle;
|
||||
}
|
||||
|
||||
td.mw-input {
|
||||
text-align: left;
|
||||
}
|
||||
|
||||
td.mw-submit {
|
||||
text-align: left;
|
||||
white-space: nowrap;
|
||||
}
|
||||
|
||||
@import 'content.links.less';
|
||||
@import 'content.thumbnails-legacy.less';
|
||||
@import 'interface.category.less';
|
||||
@import '../mediawiki.action.styles/styles.less';
|
||||
|
||||
/* The auto-generated edit comments */
|
||||
.autocomment,
|
||||
.autocomment a,
|
||||
.autocomment a:visited {
|
||||
color: #72777d;
|
||||
}
|
||||
|
||||
/**
|
||||
* Recreating deleted page warning
|
||||
* Reupload file warning
|
||||
* Page protection warning
|
||||
* incl. log entries for these warnings
|
||||
*/
|
||||
|
||||
/* (show/hide) revision deletion links */
|
||||
span.mw-revdelundel-link,
|
||||
strong.mw-revdelundel-link {
|
||||
font-size: 90%;
|
||||
}
|
||||
|
||||
/* red links; see T38276 */
|
||||
a.new {
|
||||
color: #ba0000;
|
||||
}
|
||||
|
||||
@import 'content.tables.less';
|
||||
|
||||
/* Error, warning, success and neutral messages */
|
||||
.error,
|
||||
.warning,
|
||||
.success {
|
||||
font-size: larger;
|
||||
}
|
||||
|
||||
.error {
|
||||
color: #d33;
|
||||
}
|
||||
|
||||
.warning {
|
||||
color: #ac6600;
|
||||
}
|
||||
|
||||
.success {
|
||||
color: #14866d;
|
||||
}
|
||||
|
||||
.visualClear {
|
||||
clear: both;
|
||||
}
|
||||
|
||||
@import '../mediawiki.pager.styles/DataTable.less';
|
||||
|
||||
.mw-ajax-loader {
|
||||
background-image: url( images/ajax-loader.gif );
|
||||
background-position: center center;
|
||||
background-repeat: no-repeat;
|
||||
padding: 16px;
|
||||
position: relative;
|
||||
top: -16px;
|
||||
}
|
||||
|
||||
.mw-small-spinner {
|
||||
padding: 10px !important; /* stylelint-disable-line declaration-no-important */
|
||||
margin-right: 0.6em;
|
||||
background-image: url( images/spinner.gif );
|
||||
background-position: center center;
|
||||
background-repeat: no-repeat;
|
||||
}
|
||||
|
||||
@import 'i18n-all-lists-margins.less';
|
||||
@import 'i18n-headings.less';
|
||||
@import 'i18n-ordered-lists.less';
|
||||
@import 'toc/i18n.less';
|
||||
|
||||
/* Print footer should be hidden by default in screen. */
|
||||
.printfooter {
|
||||
display: none;
|
||||
}
|
||||
|
||||
/* For developers */
|
||||
.xdebug-error {
|
||||
position: absolute;
|
||||
z-index: 99;
|
||||
}
|
||||
|
||||
@import 'interface-edit-section-links.less';
|
||||
|
||||
/* Prevent citations and subscripts from interfering with the line-height */
|
||||
sup, /* FIXME: Remove after adding 'normalize.less' added to all 'legacy.less' calling skins. */
|
||||
sub {
|
||||
line-height: 1;
|
||||
}
|
||||
Loading…
Reference in a new issue