Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Inner loop optimization: reverse order of conditions for language variant link check, so the condition short-circuits correctly and we can skip the expensive per-link lookup.

Browse source
This commit is contained in:
Brion Vibber 2004-11-22 10:05:11 +00:00
parent e85fb2969c
commit f8c3d4bfb4
1 changed files with 4 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
includes/Parser.php
View file

@ -1167,8 +1167,8 @@ class Parser
# Loop for each link
for ($k = 0; isset( $a[$k] ); $k++) {
$line = $a[$k];
wfProfileIn( $fname.'-prefixhandling' );
if ( $useLinkPrefixExtension ) {
wfProfileIn( $fname.'-prefixhandling' );
if ( preg_match( $e2, $s, $m ) ) {
$prefix = $m[2];
$s = $m[1];
@ -1180,8 +1180,8 @@ class Parser
$prefix = $first_prefix;
$first_prefix = false;
}
wfProfileOut( $fname.'-prefixhandling' );
}
wfProfileOut( $fname.'-prefixhandling' );
$might_be_img = false;
@ -1225,8 +1225,8 @@ class Parser
#check other language variants of the link
#if the article does not exist
if( $nt->getArticleID() == 0
&& $checkVariantLink ) {
if( $checkVariantLink
&& $nt->getArticleID() == 0 ) {
$wgContLang->findVariantLink($link, $nt);
}
@ -3137,7 +3137,6 @@ class ParserOptions
# Get user options
function initialiseFromUser( &$userInput ) {
global $wgUseTeX, $wgUseDynamicDates, $wgInterwikiMagic, $wgAllowExternalImages;
$fname = 'ParserOptions::initialiseFromUser';
wfProfileIn( $fname );
if ( !$userInput ) {