Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Can't return values from functions that don't return anything

Browse source 
Change-Id: If964ce2f39904f1e9e3101e7cafaa6a96d58adfc
This commit is contained in:
Reedy 2012-04-19 14:07:40 +01:00
parent 01c99c8541
commit f8d2958da9
4 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
includes/api/ApiQueryBase.php
View file

@ -233,7 +233,7 @@ abstract class ApiQueryBase extends ApiBase {
*/
protected function addTimestampWhereRange( $field, $dir, $start, $end, $sort = true ) {
$db = $this->getDb();
return $this->addWhereRange( $field, $dir,
$this->addWhereRange( $field, $dir,
$db->timestampOrNull( $start ), $db->timestampOrNull( $end ), $sort );
}

2
includes/db/ORMRow.php
View file

@ -207,7 +207,7 @@ abstract class ORMRow {
* @param integer|null $id
*/
public function setId( $id ) {
return $this->setField( 'id', $id );
$this->setField( 'id', $id );
}
/**

2
includes/upload/UploadFromStash.php
View file

@ -99,7 +99,7 @@ class UploadFromStash extends UploadBase {
// chooses one of wpDestFile, wpUploadFile, filename in that order.
$desiredDestName = $request->getText( 'wpDestFile', $request->getText( 'wpUploadFile', $request->getText( 'filename' ) ) );
return $this->initialize( $fileKey, $desiredDestName );
$this->initialize( $fileKey, $desiredDestName );
}
/**

2
includes/upload/UploadFromUrl.php
View file

@ -93,7 +93,7 @@ class UploadFromUrl extends UploadBase {
if ( !$desiredDestName ) {
$desiredDestName = $request->getText( 'wpUploadFileURL' );
}
return $this->initialize(
$this->initialize(
$desiredDestName,
trim( $request->getVal( 'wpUploadFileURL' ) ),
false