Merge "Replace PreferencesFormLegacy usages with PreferencesFormOOUI"

This commit is contained in:
jenkins-bot 2019-04-14 01:10:32 +00:00 committed by Gerrit Code Review
commit f950cc221e
4 changed files with 7 additions and 6 deletions

View file

@ -43,7 +43,7 @@ use MWTimestamp;
use OutputPage;
use Parser;
use ParserOptions;
use PreferencesFormLegacy;
use PreferencesFormOOUI;
use Psr\Log\LoggerAwareTrait;
use Psr\Log\NullLogger;
use Skin;
@ -1430,7 +1430,7 @@ class DefaultPreferencesFactory implements PreferencesFactory {
public function getForm(
User $user,
IContextSource $context,
$formClass = PreferencesFormLegacy::class,
$formClass = PreferencesFormOOUI::class,
array $remove = []
) {
// We use ButtonWidgets in some of the getPreferences() functions

View file

@ -22,6 +22,7 @@ namespace MediaWiki\Preferences;
use HTMLForm;
use IContextSource;
use PreferencesFormOOUI;
use User;
/**
@ -62,7 +63,7 @@ interface PreferencesFactory {
public function getForm(
User $user,
IContextSource $contextSource,
$formClass = \PreferencesFormLegacy::class,
$formClass = PreferencesFormOOUI::class,
array $remove = []
);

View file

@ -106,7 +106,7 @@ class SpecialPreferences extends SpecialPage {
* Get the preferences form to use.
* @param User $user The user.
* @param IContextSource $context The context.
* @return PreferencesFormLegacy|HTMLForm
* @return PreferencesFormOOUI|HTMLForm
*/
protected function getFormObject( $user, IContextSource $context ) {
$preferencesFactory = MediaWikiServices::getInstance()->getPreferencesFactory();

View file

@ -67,7 +67,7 @@ class DefaultPreferencesFactoryTest extends \MediaWikiTestCase {
$testUser = $this->getTestUser();
$form = $this->getPreferencesFactory()->getForm( $testUser->getUser(), $this->context );
$this->assertInstanceOf( PreferencesFormLegacy::class, $form );
$this->assertInstanceOf( PreferencesFormOOUI::class, $form );
$this->assertCount( 5, $form->getPreferenceSections() );
}
@ -162,7 +162,7 @@ class DefaultPreferencesFactoryTest extends \MediaWikiTestCase {
$configMock = new HashConfig( [
'HiddenPrefs' => []
] );
$form = $this->getMockBuilder( PreferencesFormLegacy::class )
$form = $this->getMockBuilder( PreferencesFormOOUI::class )
->disableOriginalConstructor()
->getMock();