Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

tests: Use MW_VERSION instead of deprecated $wgVersion

Browse source 
Change-Id: Ie4d1c7e660535fff9d0513b7ca4e6479f12bd51b
This commit is contained in:
Kevin Israel 2023-01-05 05:17:09 -05:00
parent d8ffa89a2f
commit f9fb7d6988
3 changed files with 4 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
.phpcs.xml
View file

@ -15,7 +15,6 @@
<exclude name="MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName" />
<exclude name="MediaWiki.Usage.DbrQueryUsage.DbrQueryFound" />
<exclude name="MediaWiki.Usage.DeprecatedGlobalVariables.Deprecated$wgTitle" />
<exclude name="MediaWiki.Usage.DeprecatedGlobalVariables.Deprecated$wgVersion" />
<exclude name="MediaWiki.Usage.ExtendClassUsage.FunctionVarUsage" />
<exclude name="MediaWiki.Usage.ForbiddenFunctions.passthru" />
<exclude name="MediaWiki.Usage.SuperGlobalsUsage.SuperGlobals" />

4
tests/phpunit/includes/import/ImportExportTest.php
View file

@ -176,10 +176,10 @@ class ImportExportTest extends MediaWikiLangTestCase {
* @return string[]
*/
private function getSiteVars( $schemaVersion ) {
global $wgSitename, $wgDBname, $wgVersion, $wgCapitalLinks;
global $wgSitename, $wgDBname, $wgCapitalLinks;
$vars = [];
$vars['mw_version'] = $wgVersion;
$vars['mw_version'] = MW_VERSION;
$vars['schema_version'] = $schemaVersion;
$vars['site_name'] = $wgSitename;

4
tests/phpunit/maintenance/PageDumpTestDataTrait.php
View file

@ -253,9 +253,9 @@ trait PageDumpTestDataTrait {
}
private function setSiteVarMappings( DumpAsserter $asserter ) {
global $wgSitename, $wgDBname, $wgVersion, $wgCapitalLinks;
global $wgSitename, $wgDBname, $wgCapitalLinks;
$asserter->setVarMapping( 'mw_version', $wgVersion );
$asserter->setVarMapping( 'mw_version', MW_VERSION );
$asserter->setVarMapping( 'schema_version', $asserter->getSchemaVersion() );
$asserter->setVarMapping( 'site_name', $wgSitename );