Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

SearchResult: MW version number should be a string in wfDeprecated call

Browse source 
Seems this was a typo and I think 1.32 which is a double/float will be
implicitly converted to true (bool) because it will resolve 1.32 to 1 as
integer and then 1 which maps to true (bool).

To avoid this, use '1.32' instead of the integer form of the version.

Change-Id: I2420396e110284f582cd79820ffc6064e247b4b9
This commit is contained in:
Derick Alangi 2019-05-14 12:28:35 +01:00 committed by Reedy
parent 8c59f43b33
commit facddc488a
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
includes/search/SearchResult.php
View file

@ -285,7 +285,7 @@ class SearchResult {
if ( $extensionData instanceof Closure ) {
$this->extensionData = $extensionData;
} elseif ( is_array( $extensionData ) ) {
wfDeprecated( __METHOD__ . ' with array argument', 1.32 );
wfDeprecated( __METHOD__ . ' with array argument', '1.32' );
$this->extensionData = function () use ( $extensionData ) {
return $extensionData;
};