From 77d503db09585bf56e183437534eb762b249c2a0 Mon Sep 17 00:00:00 2001
From: DannyS712 <DannyS712.enwiki@gmail.com>
Date: Fri, 21 Feb 2020 05:01:25 +0000
Subject: [PATCH] Remove Revision::loadFromId(), deprecated and unused

Bug: T242311
Change-Id: I0c8fe834da79cb6db3c2268df50ba460fa97d981
---
 includes/Revision.php                          | 16 ----------------
 includes/Revision/RevisionStore.php            | 18 ------------------
 .../Revision/RevisionStoreDbTestBase.php       | 15 ---------------
 tests/phpunit/includes/RevisionDbTestBase.php  | 12 ------------
 4 files changed, 61 deletions(-)

diff --git a/includes/Revision.php b/includes/Revision.php
index 556bef54549..f0aa06d7154 100644
--- a/includes/Revision.php
+++ b/includes/Revision.php
@@ -230,22 +230,6 @@ class Revision implements IDBAccessObject {
 		return new Revision( $rec );
 	}
 
-	/**
-	 * Load a page revision from a given revision ID number.
-	 * Returns null if no such revision can be found.
-	 *
-	 * @deprecated since 1.31, use RevisionStore::getRevisionById() instead.
-	 *
-	 * @param IDatabase $db
-	 * @param int $id
-	 * @return Revision|null
-	 */
-	public static function loadFromId( $db, $id ) {
-		wfDeprecated( __METHOD__, '1.31' ); // no known callers
-		$rec = self::getRevisionStore()->loadRevisionFromId( $db, $id );
-		return $rec ? new Revision( $rec ) : null;
-	}
-
 	/**
 	 * Load either the current, or a specified, revision
 	 * that's attached to a given page. If not attached
diff --git a/includes/Revision/RevisionStore.php b/includes/Revision/RevisionStore.php
index c50ca3dd073..e59a4509646 100644
--- a/includes/Revision/RevisionStore.php
+++ b/includes/Revision/RevisionStore.php
@@ -2387,24 +2387,6 @@ class RevisionStore
 		}
 	}
 
-	/**
-	 * Load a page revision from a given revision ID number.
-	 * Returns null if no such revision can be found.
-	 *
-	 * MCR migration note: this corresponds to Revision::loadFromId
-	 *
-	 * @note direct use is deprecated!
-	 * @todo remove when unused! there seem to be no callers of Revision::loadFromId
-	 *
-	 * @param IDatabase $db
-	 * @param int $id
-	 *
-	 * @return RevisionRecord|null
-	 */
-	public function loadRevisionFromId( IDatabase $db, $id ) {
-		return $this->loadRevisionFromConds( $db, [ 'rev_id' => intval( $id ) ] );
-	}
-
 	/**
 	 * Load either the current, or a specified, revision
 	 * that's attached to a given page. If not attached
diff --git a/tests/phpunit/includes/Revision/RevisionStoreDbTestBase.php b/tests/phpunit/includes/Revision/RevisionStoreDbTestBase.php
index ee4a7bcb9ba..bfb4de0f5e4 100644
--- a/tests/phpunit/includes/Revision/RevisionStoreDbTestBase.php
+++ b/tests/phpunit/includes/Revision/RevisionStoreDbTestBase.php
@@ -1337,21 +1337,6 @@ abstract class RevisionStoreDbTestBase extends MediaWikiTestCase {
 		$this->assertRevisionExistsInDatabase( $restored );
 	}
 
-	/**
-	 * @covers \MediaWiki\Revision\RevisionStore::loadRevisionFromId
-	 */
-	public function testLoadRevisionFromId() {
-		$title = Title::newFromText( __METHOD__ );
-		$page = WikiPage::factory( $title );
-		/** @var Revision $rev */
-		$rev = $page->doEditContent( new WikitextContent( __METHOD__ ), __METHOD__ )
-			->value['revision'];
-
-		$store = MediaWikiServices::getInstance()->getRevisionStore();
-		$result = $store->loadRevisionFromId( wfGetDB( DB_MASTER ), $rev->getId() );
-		$this->assertRevisionRecordMatchesRevision( $rev, $result );
-	}
-
 	/**
 	 * @covers \MediaWiki\Revision\RevisionStore::loadRevisionFromPageId
 	 */
diff --git a/tests/phpunit/includes/RevisionDbTestBase.php b/tests/phpunit/includes/RevisionDbTestBase.php
index e4065428d33..40b84b5a5c8 100644
--- a/tests/phpunit/includes/RevisionDbTestBase.php
+++ b/tests/phpunit/includes/RevisionDbTestBase.php
@@ -1104,18 +1104,6 @@ abstract class RevisionDbTestBase extends MediaWikiTestCase {
 		$this->assertSame( $content, $content2 );
 	}
 
-	/**
-	 * @covers Revision::loadFromId
-	 */
-	public function testLoadFromId() {
-		$rev = $this->testPage->getRevision();
-		$this->hideDeprecated( 'Revision::loadFromId' );
-		$this->assertRevEquals(
-			$rev,
-			Revision::loadFromId( wfGetDB( DB_MASTER ), $rev->getId() )
-		);
-	}
-
 	/**
 	 * @covers Revision::loadFromPageId
 	 */