Aaron Schulz
770c9d8c2e
Renamed "wfShellMaintenanceCmd" function and new, unused, het-deploy, hook
...
to "wfShellWikiCmd". The old function now remains as a wrapper. The term "maintenance" is too restrictive.
Change-Id: I5c23d6475fd1aca374ee57b89212eee3a0d8cea1
2012-04-04 16:48:55 -07:00
Santhosh Thottingal
c56cca551e
(bug 32748) unicode URL for articles print version
...
Printer friendly version of article must encode URL in unicode.
- Patch originally written by Brion Vibber
https://bugzilla.wikimedia.org/attachment.cgi?id=9593
- introduces wfExpandIRI() global function, uses wfExpandIRI_callback.
- phpunit test.
Change-Id: I348b9f1d2ce65cb14f20d4a5751ac9359c8b8316
2012-04-02 18:14:41 +02:00
Tim Starling
4b8e45d604
* Removed the $method parameters from MWCryptRand. Apparently Dantman didn't know about our awesome debug traceback functions like wfGetAllCallers(). The weird optional-middle-parameter calling convention thankfully disappears as a consequence.
...
* Reduced the amount of debug log noise slightly, removing a few redundant messages.
2012-03-21 10:27:34 +00:00
Daniel Friesen
e2ee009e5c
Commit the cryptrand project worked on in git:
...
- MWCryptRand: A new api for generating cryptographic randomness for security tokens. Uses whatever cryptographic source is available and if not falls back to using random state and clock drift.
- wfRandomString - A simple non-cryptographic pesudo-random string generation function to replace wfGenerateToken which was written pretending to be secure when it's really not.
- Core updates to use MWCryptRand in various places:
-- user_token generation (to do this we stop generating user_token implicitly and only generate it when needed to avoid depleting the system's entropy pool by reading random data we'll never use)
-- email confirmation token generation
-- password salt generation
-- temporary password generation
-- Generation of the automatic watchlist token
-- login and create user tokens
-- session ids when php's entropy sources are not set
-- the installer when generating wgSecretKey and the upgrade key
2012-03-20 05:17:40 +00:00
Aaron Schulz
7c54a34730
Reverted r113688, r113691 per CR and filed #61440 upstream.
2012-03-19 18:28:47 +00:00
Jeroen De Dauw
4febcf9cc1
docs++
2012-03-15 22:40:27 +00:00
Aaron Schulz
a6a58fd0dd
Made wfShellMaintenanceCmd() not totally broken due to excess shell escaping.
2012-03-13 00:05:23 +00:00
Alexandre Emsenhuber
73f6907199
* Put the timer stuff after leading line breaks in debug log entries (mainly for the first call on a request) so that they are placed near the remaing text and not on its own line
...
* Normalise line breaks in the first entry on a web request so that it's consistent with the one for command line requests
2012-03-12 19:01:44 +00:00
Robin Pepermans
9184dc83d6
Update core usage of getLanguageName[s].
2012-03-08 20:56:26 +00:00
Antoine Musso
6e7dfac65a
move wfRecursiveRemoveDir to global functions
...
That useful method was hidden in SeleniumWebSettings. I need it to clean
up test files leakages.
2012-02-24 15:41:06 +00:00
Alexandre Emsenhuber
e6fbfecf46
Added wfDeprecated() call to wfSpecialList() now there no more calls to that function in core or extensions
2012-02-16 12:59:48 +00:00
Alexandre Emsenhuber
72cafa3c8d
Move wfIncrStats() near other debugging functions
2012-02-15 16:17:02 +00:00
Alexandre Emsenhuber
dfa3eca14c
Always send 1 for "-total" item in wfIncrStats() when destination is UDP; it should not depend on the $count parameter
2012-02-14 14:10:32 +00:00
Brian Wolff
11f4db8b2a
follow-up r111342. Document the callerOffset paramter being used per CR.
2012-02-13 20:29:41 +00:00
Robin Pepermans
fb3ae443ef
Remove all usage of wfUILang(), deprecated in 1.18. Also some other minor tweaks. Didn't remove wfUILang itself yet in case someone uses older versions of the extensions with trunk/1.20.
2012-02-13 20:26:02 +00:00
Brian Wolff
d5b26e049a
Give a warning when people use $wgArticle. Add's a class that can be used to give warnings for other globals too.
...
See discussion on r111168.
Of course no one will see warning because trunk has $wgDeprecationReleaseLimit set to 1.17 by default
(<rant>have I mentioned how I don't like that variable. People enable warnings to be *warned* about
things. Making it so people won't get warned about things until a couple months after we've decided people
should stop using function/interface/etc defeats the purpose of having warnings</rant>)
p.s. Wasn't sure if this waranted something in the release notes, I don't think it does (It's just adding a warning)
but wasn't sure.
2012-02-13 00:19:06 +00:00
Antoine Musso
a600f8a781
revert core part of r111231
...
That one removed wfLoadExtensionMessages() . We do not want to break
back compatiliblity right now.
2012-02-12 19:40:13 +00:00
Siebrand Mazeland
53e0d99f4b
* Remove last remaining traces of wfLoadExtensionMessages().
...
* Add missing action message and remove unused global in UploadLocal.
* Some whitespace updates in Maps.
2012-02-11 12:17:58 +00:00
Sam Reed
76246b9bf5
More return documentation
2012-02-09 21:33:27 +00:00
Sam Reed
7b25f8231f
Fixing some of the "@return true" or "@return false", need to be "@return bool" and then the metadata can say true if foo, false if bar
...
Other documentation improvements
2012-02-09 19:30:01 +00:00
Sam Reed
e1d83d5721
Fixing some of the "@return true" or "@return false", need to be "@return bool" and then the metadata can say true if foo, false if bar
...
Other documentation improvements
2012-02-09 18:01:54 +00:00
John Du Hart
daeb57099d
Fixes bug 33165 - GlobalFunctions.php line 1312: Call to a member function getText() on a non-object
2012-02-07 02:49:28 +00:00
Alexandre Emsenhuber
a885da4e64
Moved wfDeprecated() and wfWarn() near other debug-related functions
2012-02-03 09:54:40 +00:00
Alexandre Emsenhuber
afab06cc73
wfTime() -> microtime( true ), no need to use the former which is just a wrapper to the latter
2012-02-03 08:32:34 +00:00
Alexandre Emsenhuber
13ba0295e2
Follow-up r110591: remove unused global declaration
2012-02-02 23:01:36 +00:00
Alexandre Emsenhuber
b6e7b2d9fd
* Always add the hostname in wfDebugLog(), whatever $wgShowHostnames is, since that setting is for user display, not internal stuff
...
* Use wfHostname() and wfWikiId() instead of executing "hostname" command and $wgDBname respectively for consistency
2012-02-02 16:35:02 +00:00
Alexandre Emsenhuber
bb7b900db4
Use $wgRequestTime in wfDebugTimer() to get the time since the start of the request instead the difference with the first call so that the time before that call is not ignored and for consistency with other time displays.
2012-02-02 10:33:42 +00:00
Max Semenik
55cb51e4c0
HTML 2???
2012-02-01 15:44:32 +00:00
Tim Starling
6db5545f66
Fix for r109720: replace the last two regexes with plain string functions. The regular expression used for stripping the last path component from the output was inefficient, because PCRE does not optimise "$" anchors correctly. It scans the entire string forwards, instead of scanning backwards starting from the anchor. Passes tests.
2012-01-23 19:35:05 +00:00
gicode
f174914db9
Follow-up 102587 to address performance concerns in wfRemoveDotSegments.
2012-01-22 04:57:37 +00:00
Sam Reed
29e672787c
Documentation
...
Remove unused globals
2012-01-19 17:27:29 +00:00
Antoine Musso
6f1d1c5245
reverts wgDeprecationWhitelist
...
Per wikitech-l
Reverts r106883 and r106946
2012-01-16 08:59:17 +00:00
Jeroen De Dauw
f93a0bbc56
revert r108508 which reverted for no good reason
2012-01-11 14:11:06 +00:00
Antoine Musso
6203ba8874
reverts $wgDeprecationWhitelist
...
There is no point in ignoring a deprecated function. The call really need
to be migrated OR the core function should not be deprecated if there is
any kind of valid usage.
If you really want to hide notifications, uses:
$wgDevelopmentWarnings = false;
Reverts r106993 r106946
2012-01-10 15:40:01 +00:00
Aaron Schulz
1d77bc94c2
* Cleanup for r108175: made if easier for extensions to interact with each other in TitleReadWhitelist hook. A handler can set $whitelisted to true to whitelist the page or it can set it to false and return false (most restrictive wins).
...
* Added some hook doc comments.
2012-01-06 06:16:05 +00:00
John Du Hart
7e9d750cc7
Implemented console panel in debug toolbar
2012-01-03 05:56:36 +00:00
Jeroen De Dauw
0ddef438be
partial revert of r106872 after discussion with Brion on #mediawiki irc
2011-12-20 22:45:14 +00:00
Brion Vibber
65f4955351
Revert r106456, r106485: system-wide setting seems to be intended to apply only to specific extensions' code but wouldn't? Also weird config parameter combining two unrelated things into one.
2011-12-20 21:52:18 +00:00
Aaron Schulz
5275f9b097
Merged FileBackend branch. Manually avoiding merging the many prop-only changes SVN likes to sprinkle in (easy to spot from the change list). Did not add SwiftFileBackend.php as it still is in development.
2011-12-20 03:52:06 +00:00
Jeroen De Dauw
5d3237fb9f
follow up to r106456 - use one setting instead two, which apparently made my commit into a fixme
2011-12-16 23:13:10 +00:00
Jeroen De Dauw
9952b6692c
introduce a new setting that allows extension authors to whitelist deprecated funtion usage for functions they do not wish to update due to backward compat reasons for a while
2011-12-16 18:32:45 +00:00
Jeroen De Dauw
43f00eb80c
follow up to r106393 - re-add these notices, since now they wont show for people that change the depr limit to see them
2011-12-16 00:24:00 +00:00
Jeroen De Dauw
e04afc0bd0
Follow up to r106037; fix location of check
2011-12-13 16:42:56 +00:00
Jeroen De Dauw
b23168e057
Follow up to r105979;
2011-12-13 15:49:52 +00:00
Raimond Spekking
26bc235560
Partly revert r105985 for now: Flooding of translatewiki.net log/channel:
...
PHP Notice: Use of wfUILang was deprecated in MediaWiki 1.18. [Called from TalkpageView::show in /www/w/extensions/LiquidThreads/pages/TalkpageView.php at line 289] in /www/w/includes/GlobalFunctions.php on line 3520
2011-12-13 10:40:32 +00:00
Jeroen De Dauw
49cdca93be
add missing deprecation notices and added deprecation version to existing ones
2011-12-13 05:19:05 +00:00
Jeroen De Dauw
6baf97c1df
add support for passing a component arg to this function, so it can be used by extensions as well (ie function foo depracted in extension bar 4.2)
2011-12-13 04:42:03 +00:00
Daniel Friesen
57c8fe18c7
Update wfArrayToCGI and wfCgiToArray:
...
- 'foo' => '' now outputs "&foo=" instead of the key being omitted
- 'foo' => null and 'foo' => false now omit the key instead of outputting "&foo="
- Added a test to make sure that 'foo' => true outputs "&foo=1"
- Fixed a php notice caused when passing a =value-less bit like "&qwerty" to wfCgiToArray by treating it like php and extracting it as 'qwerty' => ''
- Updated tests
2011-12-11 18:25:23 +00:00
Tim Starling
4be17a47f4
Revert r102504 (allow ESC in debug output): the justification in the comment above seems very reasonable to me, and is in fact an argument for stripping only ESC, since that's the only character that can change terminal modes. You could always make a highlighter pipe script for your wfDebugGreen(), instead of tailing the log directly.
2011-12-09 06:03:27 +00:00
Niklas Laxström
2b79fc74e5
Revert r97468 and implemented it in another way suggested by Tim
2011-12-08 09:07:10 +00:00
