By default while using vscode live share it is hard to work on
skins and extensions of mediawiki using the core repo as a project
base, as extensions and skins are included in .gitignore files.
Configuration of the sharing behaviour is possible and documented at
https://docs.microsoft.com/en-us/visualstudio/liveshare/reference/security
The files added in this commit mean that by default:
- .gitignore files are treated in the default way for the system
meaning they are hidden, but accessible.
- core node_modules and vendor and shared and in the tree
- extensions and skins are shared and in the tree
Change-Id: I5e44483bcf09aa2fb6d568de1e0689a76ab7338a
Fixed links to mediawiki.org so pages can load on user defined
language instead of default ENGLISH.
Added == User Information == on first line as it is already in
README file for extensions directory
Change-Id: Iadc8eae48f1274d3e50e5b147565d197b1b7d3be
Also revert the automatic "Update git submodules" commits since then.
This reverts commit 264fc98588.
Change-Id: Ica6ad77c46cc8a7f6b5576da2580ea9e07ac8637
These are actually far more useful listings than the mediawiki
group on Gitblit, which is everything MediaWiki and provides
no actual listing beyond "recently active"
Change-Id: I741cb53ca417bddfa176868fb78ce67b1475fc70
Removed common (last remaining file removed in 1e8b1dd8cf)
and added README (added in c505afca41).
Change-Id: Idc31569b29df19fb79bc2c08fba0a327d9cd334d
There are still some requests for it per bug 69277 comment 90, but per
bug 69678 comment 12 all usages have been already removed.
This is the last file in the skins/common/ directory.
Bug: 69277
Change-Id: Id9de81d0efa91fa20dfd10d56a8ae814de43ff6e
There are still some requests for it per bug 69277 comment 90, but per
bug 69678 comment 10 all usages are forward-compatible or have been
already removed.
Bug: 69277
Change-Id: If6a16fb5aa5a826a58c8dec67e3583ccf12761e2
* ajax.js, wikibits.js:
Was kept for third parties. (user scripts etc.)
* redirectltr.png, redirectrtl.png:
Was kept for cached stylesheets, after I8fa565833545e41d02 removed
usage in MediaWiki core.
* magnify-clip-rtl.png:
Was kept for third parties. (user scripts etc.)
Bug: 69277
Change-Id: I54b170b557414e2f3cda4c85053cd0f2cbefc10d
The problem here is that the path to 'wiki.png' is saved in users'
LocalSettings.
We likely should not remap the path, like we did for footer license
icons in Ic7c32e56:
* It's likely that users changed their logo image by overwriting the
file in skins/common/.
* If the normal upgrade process is followed (overwrite-uploading new
files), the old file will still be there with the skins/common/
directory.
* If it does cause problems, they'll be rather easy to notice and fix.
On the other hand, maybe we should?
* This is going to be annoying for git users.
* It will bite anyone who deletes all MediaWiki files when upgrading
via tarball, which is more likely with the recent skin system
changes encouraging users to remove old cruft from skins/ directory.
Bug: 69277
Change-Id: I175fe57048ebf9d348fb2fe67bf62cf5df389003
Also, try out a way to have per-module LESS variables defined in PHP.
This might come in handy in the future… Maybe for skin theme support?
(I recommend reviewing the file changes in the order below. :D)
includes/resourceloader/ResourceLoaderFileModule.php
* Pass the context (ResourceLoaderContext) deeper down via
readStyleFiles() and readStyleFile(). We need it to compile the
.less files for the right language.
* Extract LESS compiler creation to getLessCompiler().
* Allow passing a LESS compiler instance to compileLessFile(), rather
than getting one after the method is called.
All of the changes are backwards-compatible.
includes/resourceloader/ResourceLoaderEditToolbarModule.php
* New module to support getting the language data and passing it to
LESS variables.
It might be a good idea to factor out a reusable class for a LESS
module with additional variables, but that would require more
attention to design than I gave it.
resources/src/mediawiki.action/mediawiki.action.edit.toolbar/mediawiki.action.edit.toolbar.less
* Glue code to use the language data defined by the module above and
put it in final CSS.
includes/EditPage.php
* Do not hardcode image URLs in output HTML, as they are provided in
CSS now. This gets rid of some usage of globals.
In fact, we should be able to finally move the inline JavaScript
calls out of getEditToolbar(), but I'm already introducing too many
changes for one patch. That can be done later.
languages/Language.php
* Add getImageFiles() to complement existing getImageFile() method.
Misleadingly named, it returns paths for images for the toolbar
only (and no other ones at all).
skins/common/ → resources/src/mediawiki.action/mediawiki.action.edit.toolbar/
* Moved all of the button images to new location.
Also, boring cleanup that was harder before because we treated the
paths as public API:
* Placed default ones in en/ subdirectory.
* Renamed cyrl/ to ru/.
* Renamed ksh/button_S_italic.png → ksh/button_italic.png.
languages/messages/
* Adjusting paths and filenames for the changes above.
resources/src/mediawiki.action/mediawiki.action.edit.css
resources/src/mediawiki.action/mediawiki.action.edit.js
* Added styles and updated the script to make it possible to have
non-<img> elements as toolbar buttons.
* Consolidated styles that were already required, but defined
somewhere else:
* `cursor: pointer;` (from shared.css)
* `vertical-align: middle;` (from commonElements.css)
Bug: 69277
Change-Id: I39d8ed4258c7da0fe4fe4c665cdb26c86420769c
poweredby_mediawiki_88x31.png is straightforward, just need to update
some paths.
The six license icons are more problematic, as the paths to them are saved
in users' LocalSettings. We're remapping them in Setup.php.
Bug: 69277
Change-Id: Ic7c32e56043cfbf94ef2271de4ff41ef18fbeee7
* Created a ResourceLoader module for redirect page styling.
* Fixed a couple of bugs in Article code.
Keeping two of the old files for a while because they might still be
referenced by something (bug 69277 comment 11).
Bug: 69277
Change-Id: I8fa565833545e41d0232101566da8c5ffa850e36
This patch introduces the assets/ directory, which will be used for
static files included with MediaWiki that can't meaningfully be loaded
via ResourceLoader.
Bug: 69277
Change-Id: Ifd87387f20a6355a6e273628b37735c207e4c53a
This is a BREAKING CHANGE, as we have used the names of these three
files in skins/common/ as a "public API" for skins for a long time.
Doing so has been deprecated (but still supported) in 1.23.
We must clear them out at some point, and now is as good a time as
ever, with the 1.23 LTS release still supporting the old way.
Skins may no longer rely on the presence of commonElements.css,
commonContent.css and commonInterface.css in skins/common/ and
include them in their style modules. The corresponding ResourceLoader
modules must be used instead:
- skins/common/commonElements.css → 'mediawiki.skinning.elements' module
- skins/common/commonContent.css → 'mediawiki.skinning.content' module
- skins/common/commonInterface.css → 'mediawiki.skinning.interface' module
Follow-up to I3947eaac (where I said I intend to do this) and I56758908.
Bug: 69277
Change-Id: Id8456c570ff406822a8befad8f42f528ef5bd3a6
Unused in core, unused in extensions (as far as I can tell) and unused
on-wiki (as far as I can tell).
There are still requests for it (according to bug 69277 comment 11), but
we can't do anything about that if we can't tell where they come from.
Bug: 69277
Change-Id: I2cf158229955c93ecbf29c83d04df121e4b4addc
Redrawn the images with SVG versions.
Intentionally did not preserve the value of the 'alt' attribute of the old
images, it doesn't seem very useful to me. Instead, added 'title'
attributes on the sort links that describe their action. This should be
more useful than the old version for both visual and aural mediums.
Bug: 69277
Change-Id: Ibaec75e81d3eb8338d911ac84d91570047f475f5
Moved files from directory: skins/common/images → resources/src/mediawiki/images
and renamed:
* arrow_disabled_last_25.png → pager-arrow-disabled-fastforward-ltr.png
* arrow_disabled_first_25.png → pager-arrow-disabled-fastforward-rtl.png
* arrow_disabled_right_25.png → pager-arrow-disabled-forward-ltr.png
* arrow_disabled_left_25.png → pager-arrow-disabled-forward-rtl.png
* arrow_last_25.png → pager-arrow-fastforward-ltr.png
* arrow_first_25.png → pager-arrow-fastforward-rtl.png
* arrow_right_25.png → pager-arrow-forward-ltr.png
* arrow_left_25.png → pager-arrow-forward-rtl.png
The new names are not very intuitive, but there's a mostly reasonable
system behind them and we need names like this to have them
automatically flipped for RTL styles.
Bug: 69277
Change-Id: Ica34cdd5fcc9340a94fb5e60bb34c30266953dcb
Also renamed some image files for consistency and sanity.
Added temporary symlinks to the new location for ajax.js and
wikibits.js, which still seem to get many hits for unknown reasons.
I'm going to figure this out and remove them before 1.24 release.
shared.css also appears in the access logs from bug 69277, but with
many fewer hits (it might just correspond to debug=true requests)
and failing to load a style file is a lot less problematic from
user's perspective than failing to load a script.
Bug: 69277
Change-Id: Id4a8f9470d287c73309ff526ffb88984e2d351b9
We can merge it into mediawiki.special.upload later.
It still sets wgUploadWarningObj, because that's used in a bunch of places:
commonswiki MediaWiki:UploadForm.js
commonswiki MediaWiki:UploadFormTest.js
fawiki MediaWiki:UploadForm.js
siwiki MediaWiki:UploadForm.js
commonswiki User:CuteHappyBrute/monobook.js
kowiki User:Kwj2772/UploadForm.js
sqwiki User:Euriditi/UploadForm.js
Bug: 31946
Change-Id: I4fc3dcd1f1bfb15aa130845e3de0474943b7e3fc
It was a stylesheet loaded with our RSS and Atom feeds, intended to make
them legible when shown in a regular browser. Browsers these days tend
to have their own UI for feeds (for example IE 11 and Firefox 31), and
these that don't pretty-print the XML, which means the stylesheet
provides very little added value.
Per discussion on I6268d663.
Bug: 69277
Change-Id: I2ce9650c01f8f245707f5e88ee46520c5e598ce4
Added in r16083 for Special:ImageList, which has been renamed to
Special:ListFiles in r45357, with class names being changed in the PHP
code without adjusting the CSS.
It seems no one has missed these styles over the years, so let's just
delete them.
Change-Id: I1f7775b3c7733cbfdd3f404527063e973fb80ec7
There is an ungodly number of requests for magnify-clip.png, embedding
it in CSS is probably good for performance.
It also makes it a lot easier to change the icon, or provide a vector
version (SVG or icon font).
We need to be careful to keep new CSS compatible with old HTML (HTML
is cached for up to 30 days in WMF environment), but luckily in this
case this requires just one CSS rule. Follow-up to remove it: I7a920105.
Bug: 69673
Change-Id: I849a2222fdf708573e54fa0658dbef4d9f2f665f
No design changes, just cleaning up.
* Remove dead rules (equivalent to default styles).
* Remove unnecessary !importants (added in r3300 (!), apparently to
intentionally override styles in skins at the time).
* Make commonContent.css's directionality-specific styling not depend
on shared.css (these don't have to be loaded together).
* Fix double margins for .magnify in mixed directionalities.
* Clarify that shared.css should only contain basic layout styles.
* Group together directionality-specific styles in commonContent.css,
comment about them. oldshared.css seems to intentionally not use them.
* Align commonContent.css and oldshared.css where applicable.
Change-Id: I2176d5ee73e37030c15ee5e16ba4eb0660349e15
The CSS and JS files are definitely used only by the installer.
As for the images:
* mediawiki.png is still used directly by some error pages
(includes/PHPVersionError.php, includes/templates/NoLocalSettings.php)
* ajax-loader.gif is still used by shared.css
* bullet.gif is mysteriously used by *something*, according to the
logs at bug 69277 comment 11; I currently have no idea what, so
let's keep it here for a while
* All other ones don't grep (outside of the installer itself) and
don't appear in the logs on bug 69277.
Bug: 69277
Change-Id: I9146d9211a807911a5e0cfaa1dd3ab8170f333ca
Not used in core, the only usage outside removed in Ieb5bb6f9.
Also removed two now-unused files from skins/common/.
Bug: 69675
Change-Id: Ia0e9fc2af25af903db085f2a05c04dcd9aff213e
Grepping doesn't point to any usages, and they don't appear in logs
from bug 69277 comment 11.
add.png
Arr_.png
closewindow.png
diffunderline.gif
link_icon.gif
remove.png
tooltip_icon.png
Zoom_sans.gif
Bug: 69277
Change-Id: I09c0c13b353366e83124e7ffa1fa02eeada76729
Extension GlobalUsage uses thumbs on a special page.
Special pages have no CSS class mw-content-ltr or mw-content-rtl.
This change adds a default style for magnify and thumbcaption
which gets flipped by the direction of the user interface language.
This default definition gets overwritten by the existing definition
in shared.css based on the content direction:
/**
* Image captions
*/
/* @noflip */
.mw-content-ltr .thumbcaption {
text-align: left;
}
/* @noflip */
.mw-content-rtl .thumbcaption {
text-align: right;
}
/* @noflip */
.mw-content-ltr .magnify {
float: right;
}
/* @noflip */
.mw-content-rtl .magnify {
float: left;
}
Bug: 69215
Change-Id: Ia6aa7c896fbedfe40b97af7358c5fa89223251b3
