This time done in a nice, centralized fashion, reducing LOC for callers
even if HTML 5 is disabled. The implementation is a new Html class,
similar to Xml but intended to be HTML-specific from the beginning
instead of half-heartedly attempting to provide generic XML services but
actually with lots of HTML-specific stuff tacked on.
As part of the new Html class, a global config option $wgWellFormedXml
is added. It's set to true by default, but if set to false, the Html
class will drop some things that HTML 5 doesn't require, like
self-closing " />" syntax and attribute quotation marks (sometimes).
Mistake pointed out by Darth Kule on translatewiki.net, conveyed to me
by Nikerabbit. I changed the semantics of a message but didn't update
all the callers.
This splits up the message recentchanges-label-legend so that pieces of
it can be provided only when they're relevant, and more can be added
later. Any existing translations will need to be retranslated, but it's
only been a day, so creating a new message name seemed like overkill.
Follow-up to r54242.
Based on a patch submitted by svip on IRC. I also changed the <span>
for unpatrolled into an <abbr>, and created a new message in case anyone
wants to localize !, for the sake of uniformity.
* Remove large swathes of dead code, hooks that have never existed, and dormant methods.
* Remove the TalkpageArchiveView, which has been inaccessible from the UI for ages.
* Break most miscellaneous hooks out into their own file, classes/Hooks.php
* Float the reply link on the RHS.
* Organise the hooks section of LiquidThreads.php somewhat.
* Remove deprecated =& syntax in some places.
* Move scratchTitle and related methods into Threads class instead of View class.
* Kill home-grown revision insertion code from leaveTrace, and rewrite it to use Article::doEdit
* Internal documentation, variable naming as appropriate.
* Remove special-case handling for links, unnecessary now.
* Fix customizeOldChangesList, it looks like it was never properly tested. Even if it had worked, it would have put (not by the author) on every edit to a post.
* Fail fast when trying to move a non-toplevel thread.
* Add rollback, extra links to the end of new-thread recentchanges entries.
diff and cur links are now created using raw HTML instead of link(),
which they didn't really need anyway. I didn't see any other obvious
candidates for conversion to raw HTML, since other things tend to need
fancy classes and have lots of other logic. It's possible link() could
be made faster, too.
* Avoid extensive permission checks, just rely on User::isAllowed("rollback")
* Preload page_latest data in initial RC query, no need to run thousands of queries afterwards
* Add searching and filtering functionality to the existing 'test' interface.
* Add an 'examine' interface designed for testing filters against a previous change, selectable through the search interface in either the 'test' or the 'examine' view.
* Minor enabling change in ChangesList core, to allow subclassing.
-- Introduce tagging of individual changes (revisions, logs, and on recentchanges). The tags are customisable, and currently settable by the Abuse Filter and by the TorBlock extension. The tags can be styled on the various pages on which they appear.
-- Introduces a schema change, three new tables (valid_tag, change_tag, and tag_summary).
extract() is pretty much the devil and shouldn't ever be used for safe, legible code because it makes it much more difficult to analyse the code -- you have to run around trying to track down the source of local variables and there's generally a lot of pain.
Removing the FIXME comment isn't a substitute for fixing it. ;)
Changed from:
Time Page (4 changes) . . (+bytes) . . (hist) [list of editors]
To:
Time Page (4 changes; hist) . . (+bytes) . . [list of editors]
Use consistent message for the history link
Patch by Mormegil
I think I'd rather see consistent classes for common UI elements, regardless of where they appear.
For instance 'mw-rc-usertoollinks' ... We have user tool links in a hojillion places; they should all have *the same* class. If you need to distinguish those on RC from those on another page, you use a fancier selector that grabs only those in the special you want.
