Commit graph

8 commits

Author SHA1 Message Date
Umherirrender
c7ad21c25f Improve param docs
Change-Id: I746a69f6ed01c3ff000da125457df62b02d13b34
2019-11-28 19:08:59 +01:00
Tim Starling
377e1084e6 REST: Make getValidatedParams() always return an array
To stop phan from flagging every usage as "suspicious nullable".

Bug: T235355
Change-Id: Ibdcd9f4e9761858e68fae1262187a3e99affa6f9
2019-11-15 04:43:20 +00:00
Tim Starling
8299d7ae8f REST compare: bundle section offset information
Bug: T236964
Change-Id: Ib97b0fa0de682404fb9df2ecef55a3526c54a31f
2019-11-11 16:25:35 +11:00
Nikki Nikkhoui
59ec3fa342 Remove "diff" in response body in revision/{from}/compare/{to}
The fix for this is a hack until getJsonDiff() can be moved into SlotDiffRenderer and is able to extract the inner diff object

Bug: T235866
Change-Id: I0feaa2cd3727a9ae355f561dcd2751a73da99b3e
2019-10-28 09:22:49 -07:00
Nikki Nikkhoui
bb2770e0ba Remove 'response' prop. from revision comparison JSON
The 'response' property in the return JSON body was not necessary has been removed

Bug: T235864
Change-Id: I1d3d60bc1d1ba7a4fcaef3cabd5ce5bb6a39416f
2019-10-24 11:39:14 -07:00
Daimona Eaytoy
ae424ce5da build: Upgrade mediawiki-phan-config to 0.8.0
This is to ensure that the CI job is working with the new version.

Note: redundant_condition_detection should have worked as expected by
this version, but unfortunately it still has false positives.

Bug: T235049
Bug: T231636
Change-Id: Idaba6584cb5b2ff19b6455c7bbec6b89619ddbff
2019-10-22 09:16:45 +00:00
Petr Pchelko
a5bf77dc44 REST History and compare endpoints followups.
- Improve access checks for history,compare,revision handlers.
- Ensure that null is not returned in place of empty string

Bug: T235146
Bug: T231588
Bug: T235560
Change-Id: I2a15c7577fe67055367147c4f6b982c9fcdf8535
2019-10-16 15:51:33 -07:00
Petr Pchelko
8254e73a41 REST compare endpoint
An endpoint for providing diffs of the main slot in the new JSON format.

Bug: T231580
Change-Id: Ia603dabcf09b02b3f5e916522e30a9fd1cbef4f1
2019-10-12 10:16:07 -07:00