4 commits

Author	SHA1	Message	Date
Thiemo Kreuz	f10f4e05de	Remove some meaningless $this->equalTo() from tests ... This is the default behavior anyway when using ->with(). Change-Id: I64b6474280eb7da122eb22fc0afa28cca81e96c5	2021-04-22 10:47:54 +02:00
Daimona Eaytoy	535d7abf59	phpunit: Mass-replace setMethods with onlyMethods and adjust ... Ended up using grep -Prl '\->setMethods\(' . | xargs sed -r -i 's/setMethods\(/onlyMethods\(/g' special-casing setMethods( null ) -> onlyMethods( [] ) and then manual fix of failing test (from PS2 onwards). Bug: T278010 Change-Id: I012dca7ae774bb430c1c44d50991ba0b633353f1	2021-04-16 20:15:00 +02:00
DannyS712	f75f3c75ea	UserRateLimitConstraint: move detection of content model change to constraint ... A step towards a more common interface between the different constraints, detect whether the content model changes within the UserRateLimitConstraint rather than relying on EditPage to inject the answer Bug: T157658 Change-Id: Ifa35cbabe74df458784a10b3d2815a1e8e7dcdf8	2020-12-01 23:08:47 +00:00
DannyS712	05ae763ba2	EditPage: Migrate more checks to constraint ... Add - ContentModelChangeConstraint - EditRightConstraint - ImageRedirectConstraint - ReadOnlyConstraint - UserBlockConstraint - UserRateLimitConstraint Additionally: - Split EditPageTest into a separate file for all of the constraints being tested - Add a helper EditConstraintTestTrait - Add debug logging for EditConstraintRunner for the result of each constraint - Changed the order of some of the checks, which may result in a different failure code if multiple checks were going to fail, but shouldn't change the overall result of whether an edit fails or not. Bug: T157658 Change-Id: Ib8f8b62b9928544e5559c96d82bf850dd8cf9b05	2020-10-26 22:01:05 +00:00