It is better when the special page is not register,
instead of giving a hint, that this is disabled on the wiki.
See other special pages like Special:PopularPages or Special:ChangeEmail
Change-Id: I43fb118d61ddcb2536192f54ee888d55b2fbd49d
Follow-up to I17ac68014840daa47bfd4768e978e9ff2edb00db.
Replaces some ==/!= with ===/!== and other code style
changes mentioned in Gerrit comments on previous patchset.
Change-Id: I50da16bc62241491ac5c4948e0d3059b21f113dc
Rather than have separate calls to User::loadDefaults()
every time User::loadFromSession() fails, there is now just
one call in User::load() if loadFromSession() returns false.
This fixes the case where a UserLoadFromSession hook aborts
loading from session, leaving the User object uninitialized.
Change-Id: I8d1a114d7ec361b27b260791f742c473a1497f26
Signed-off-by: Tyler Anthony Romeo <tylerromeo@gmail.com>
The fix for bug 34768 (r112710, regarding the lack of width and height
attributes for the Vector skin's search button) failed to include the
corresponding changes to SkinTemplate.php.
Because BaseTemplate::makeSearchButton() only special cased the src and
alt attributes, the width and height incorrectly went on the button
element, causing HTML validation errors (and also having no effect).
This patch moves the width and height attributes to the img element
in a similar fashion to src and alt.
Change-Id: I3561fc79364ce43521823bad691c9b61f87ba375
Add the link to {{SERVER}}{{SCRIPTPATH}}/CREDITS in Special:Version
in the code and not in the interface message, which is
way more straightforward, makes the message easier and
assures that the developers are credited no matter of the current
interface language.
The following languages need interface changes after this is merged:
He, Ko, Bcl, Jv (the fact that this list is so short once again
proves the point that the link isn't set in many languages). I'll
take care of those.
Change-Id: If12c4eb8453da40ede4b9768b2dacfaf838aa2ab
* Added parameter to login link so that wpStickHTTPS
is set to true by default when the user is coming
from HTTPS.
* Added redirect in Special:Userlogin so that when
$wgSecureLogin is enabled it automatically redirects
to HTTPS.
* Adjusted User::setCookies() to add a parameter for
forcing secure/insecure cookies, and then added the
appropriate argument to Special:Userlogin so that
cookies are set appropriately.
Change-Id: I17ac68014840daa47bfd4768e978e9ff2edb00db
Added new argument to the Linker options array to allow
the forcing of an HTTP or HTTPS protocol. In order to facilitate
this, a protocol argument was added to Title::getLinkURL.
Also, an options argument was added to OutputPage::addReturnTo
so that options can be passed to the linker and so that the
returnto URL can be forced to a certain protocol.
Change-Id: Ia9cc11e310ad6ef23c221bdba3a4834e7c5556e7
This reverts commit dfbf524d35 which
was "Removed unmatched commits in Job class".
The original change was reverted n the light of the recent discussion about the DBO_TRX flag
and the intended use and bahavior of begin and commit.
See http://www.gossamer-threads.com/lists/wiki/wikitech/300087 for Tim's explanation of DBO_TRX.
This change now implements a new, alternative solution to the original problem of unmatched
calls to commit:
The Job class originally relied on implicitely started transactions. Introducing
explicit calls to begin() avoids warnings while running tests, and
causes transaxctiosn to be used also in cli (maintenance) mode.
Change-Id: I6ecb8faad06449331a79b81860fe64624d3694d4
This change causes implicit commits caused by consecutive calls to
Database::begin() without intermediate calls to Database::commit() to
be more easily tracable. The changes introduced are:
* $this->doCommit( $fname ) is now called unconcitionally if there is
an open transaction. Previously, it was not called if there were no
write operations performed in that transaction.
* A warning about implicite commits (nested transactions) is now issued
if write operations were performed OR ther DBO_TRX flag is NOT set. This
causes any unmatched calls to begin() to trigger an error in CLI mode,
notably also within unit tests.
* Implicit commits of non-write transactions in DBO_TRX mode can now be
logged by enabling $wgDebugDBTRansactions.
Besides this, this change improves the documentation of the transaction
control functions.
The rationale is that implicite commits should be more easily tracable
in production and development.
Change-Id: I1e746322c36a7c53b545bfe78e252a13cce44ea1
- Adding this now even though no browser supports it so that when one does it doesn't become a way to bypass our url() filter.
- Including missing tests for all of our insecure input filters.
- Also make sure that vendor prefixed versions like -webkit-image() are caught because most browsers are probably going to go and implement a vendor prefixed version first.
Change-Id: If73aa98b8accdb7621b0e4ff0615b61d530fa547
In the pager object, if the query was constructed
such that the index was a fully qualified field then
the 'past the end' index reference would not get
computed.
This is because $mIndexField stores the FQ field name
but $mPastTheEndRow is indexed on the non FQ name.
Therefore a warning would be generated due to a non
existent array key.
Change-Id: I52e1cbc8f7dad07de1ba5ba3bdfa2d107dfb4d93
During incident response, it was not possible to tell what API modules
were being requested and by whom, since the action parameter is often
posted. This change logs the API parameters whether they are posted or
sent in the query string.
I did try to get the API parameters from the module, but that turns out
to be difficult. Modules create submodules (generators, page sets) as
local variables, which are created in a procedural style and destroyed
before logging is done, so there is no easy way to query them for
parameter lists after execution completes.
In ApiOptionsTest, use a real ApiMain object like all the other API test
cases, rather than a mock object. Otherwise the test fails.
Change-Id: Idc786007fe61811d1874f29b5ce4762dd97b1847
