4 commits

Author	SHA1	Message	Date
MusikAnimal	2d21ee58ec	Add expiry type to ParamValidator ... This commit also changes ApiWatch to make use of the new parameter type. Other APIs will be updated to use it in a separate patch (T248196). In doing this, we are for the first using logic within a TypeDef outside the API. This seems acceptable given TypeDefs chiefly appear to serve as a validation method, with otherwise no particular logic tied to the concept of APIs. wfIsInfinity() now uses ExpiryDef::INFINITY_VALS Bug: T248508 Change-Id: If8f0df059eafb73ec9f39cc076b3a9ce2412d60a	2020-04-08 16:21:04 -04:00
Thiemo Kreuz	e1dd371e11	Make use of PHPUnit's assertCount feature where possible ... … and avoid assertEmpty() on arrays, in favor of a much more strict assertSame( [] ). Change-Id: I20266b0b1fc38a3a87666ba1b0793cb2b37d94a9	2020-03-02 15:58:41 +00:00
Brad Jorsch	d4c2f0d899	Move some validation logic from ApiStructureTest to ParamValidator ... ApiStructureTest has a lot of logic for validating Action API settings arrays during CI. Some of that logic should be part of ParamValidator instead. Bug: T242887 Change-Id: I3c3d23e38456de19179ae3e5855397316b6e4c40 Depends-On: I04de72d731b94468d8a12b35df67f359382b3742	2020-02-04 20:29:35 +00:00
Brad Jorsch	c2b1525908	API: Use ParamValidator library ... This brings significant modularization to the Action API's parameter validation, and allows the Action API and MW REST API to share validation code. Note there are several changes in this patch that may affect other code; see the entries in RELEASE-NOTES-1.35 for details. Bug: T142080 Bug: T232672 Bug: T21195 Bug: T34675 Bug: T154774 Change-Id: I1462edc1701278760fa695308007006868b249fc Depends-On: I10011be060fe6d27c7527312ad41218786b3f40d	2020-02-04 13:36:14 -05:00