Commit graph

85360 commits

Author SHA1 Message Date
Amir Sarabadani
2589076e3b Avoid fatals when the filter tags is empty
Bug: T194164
Change-Id: I418cbe2259e7c1622a58a4a310a3cd56873f16c3
2018-10-16 13:05:32 +02:00
jenkins-bot
31c35c9fb6 Merge "Simplify list-style property" 2018-10-16 05:28:33 +00:00
jenkins-bot
ad04e28eec Merge "Fix warning in doEditSectionLink() caused by not-yet-unstubbed $wgLang" 2018-10-16 03:04:06 +00:00
jenkins-bot
ecfae5b103 Merge "API: Ignore expired blocks in ApiQueryBase::showHiddenUsersAddBlockInfo()" 2018-10-15 23:07:47 +00:00
jenkins-bot
a9ce224f71 Merge "LocalisationCache: Avoid use of compact()" 2018-10-15 22:34:25 +00:00
jenkins-bot
33397ae8b6 Merge "API: Remove long-deprecated methods (and one class)" 2018-10-15 22:34:20 +00:00
jenkins-bot
8867f81ab3 Merge "CREDITS: Bump for 1.32.0 release" 2018-10-15 21:48:29 +00:00
Brad Jorsch
6ff65e57bb API: Remove long-deprecated methods (and one class)
* ApiBase::profileIn() (deprecated in 1.25)
* ApiBase::profileOut() (deprecated in 1.25)
* ApiBase::safeProfileOut() (deprecated in 1.25)
* ApiBase::profileDBIn() (deprecated in 1.25)
* ApiBase::profileDBOut() (deprecated in 1.25)
* ApiBase::dieUsage() (deprecated in 1.29)
* ApiBase::dieUsageMsg() (deprecated in 1.29)
* ApiBase::dieUsageMsgOrDebug() (deprecated in 1.29)
* ApiBase::getErrorFromStatus() (deprecated in 1.29)
* ApiBase::parseMsg() (deprecated in 1.29)
* ApiBase::setWarning() (deprecated in 1.29)
* ApiPageSet::getInvalidTitles() (deprecated in 1.26)
* ApiQueryLogEvents::addLogParams() (deprecated in 1.25)
* ApiUsageException::getCodeString() (deprecated in 1.29)
* ApiUsageException::getMessageArray() (deprecated in 1.29)
* UsageException (deprecated in 1.29)

Change-Id: Iabb2589a29cc3b46624d31358f3a6bf7b3ccbd57
2018-10-15 16:37:04 -04:00
Kunal Mehta
d0463178df LocalisationCache: Avoid use of compact()
In PHP 7.3, compact() now raises notices if the variable is undefined, which
is something that we expect. So we can check whether the key exists instead
of bothering with compat() and suppressing warnings.

Bug: T206979
Change-Id: I612049db4debd850a2e6d10bc631d31aa17be898
2018-10-15 13:35:30 -07:00
Edward Chernenko
559b0f3e54 Fix warning in doEditSectionLink() caused by not-yet-unstubbed $wgLang
In ParserOutput::getText(), $wgLang can be a StubUserLang object,
which causes a typecheck warning in doEditSectionLink().

Solution is to replace $wgLang with $context->getLanguage(),
which is always a Language object.

Change-Id: I9945e1615c3f1b7ed5c7897b9f67d7ca0450ee50
2018-10-15 23:21:02 +03:00
Volker E
928a1e6f71 Simplify list-style property
Using `none none` value is also working on older IEs, which had
issues with shorthand only `list-style: none`.

Change-Id: I7d4b075ac90fd902e0c0fbc3e11449faf71fe9b2
2018-10-15 13:03:13 -07:00
Translation updater bot
ed4d7ef057 Localisation updates from https://translatewiki.net.
Change-Id: I4b631605549ac3599ca01d59fa69e35fad6c879e
2018-10-15 21:57:04 +02:00
James D. Forrester
7fbc3e53f5 CREDITS: Bump for 1.32.0 release
Change-Id: I2187346003a53874c559fcfe23ee94d822829794
2018-10-15 11:06:39 -07:00
RazeSoldier
f3b012b51f Use "break" instead of "continue" inside a switch
"continue" statements in a switch are equivalent to "break". In PHP 7.3, will generate a warning.

Bug: T206974
Change-Id: I54bcec013ff52ab81bff09f8f7ef02f3944a5b7d
2018-10-15 23:58:26 +08:00
Brad Jorsch
377c76edbc API: Ignore expired blocks in ApiQueryBase::showHiddenUsersAddBlockInfo()
This probably went unnoticed for so long because expired blocks are
regularly cleared as long as new blocks continue being issued, so people
found that the problem "fixed" itself.

Bug: T206944
Change-Id: I6559e1ec23f4469d19684b4d931913acbccb56d4
2018-10-15 11:21:44 -04:00
jenkins-bot
0756849eb8 Merge "EmailNotification: Add newline before minor edit text" 2018-10-15 14:19:43 +00:00
jenkins-bot
ca374bc8e4 Merge "resources: Register jquery.client as foreign resource and update to v2.0.1" 2018-10-15 14:07:14 +00:00
jenkins-bot
da272d7d27 Merge "Add MessagesShn.php" 2018-10-15 13:48:07 +00:00
Martin Urbanec
0b63d08b31 Add MessagesShn.php
This localizes:
* namespaces
* special page names

Bug: T206917
Bug: T206921
Change-Id: I0d27746aca56849056098ffffa866954d97f133d
2018-10-15 14:04:21 +02:00
Timo Tijhof
609fb7bd4c resources: Register jquery.client as foreign resource and update to v2.0.1
Change-Id: Iec6414a1675dec4aeb5d9b66635d28670f094e42
2018-10-15 03:28:44 +01:00
Translation updater bot
112385bff5 Localisation updates from https://translatewiki.net.
Change-Id: I27647ca9376c400143ba52074322c4b50960db53
2018-10-14 21:54:50 +02:00
MGChecker
6cb3fa392f docs: Remove outdated information from globals.txt
design.txt doesn't exist anymore.

Bug: T111283
Change-Id: Ibb67fb721060b325114e571ba3e470a607d98884
2018-10-14 19:13:03 +00:00
jenkins-bot
b8733c7d26 Merge "jobqueue: clean up JobQueueDB::getCacheKey() to use makeGlobalKey()" 2018-10-13 23:59:35 +00:00
Translation updater bot
ffa5a48a25 Localisation updates from https://translatewiki.net.
Change-Id: I5958a3381bd070c1cb7d79e6819b638418b87165
2018-10-13 09:49:22 +02:00
Aaron Schulz
c947f3288d jobqueue: clean up JobQueueDB::getCacheKey() to use makeGlobalKey()
Change-Id: I341720fda0d242c7822f78048cb49f63538d08bc
2018-10-13 00:14:38 -07:00
Kunal Mehta
801942b564 travis: Remove PHP 7.2 from allowed failures
It's now passing!

Bug: T204884
Change-Id: Idb17630cff54b803ca5fa942b2fcf17a775edd0d
2018-10-12 23:47:42 -07:00
jenkins-bot
69d27cc0b6 Merge "Output only to stderr in unit tests" 2018-10-13 06:29:17 +00:00
jenkins-bot
6928652735 Merge "SlotDiffRenderer: add utility method for parameter type checks" 2018-10-13 05:27:16 +00:00
jenkins-bot
86529fef92 Merge "Linker: Document parseComment() as returning HTML" 2018-10-13 05:23:43 +00:00
jenkins-bot
b6fecdf6fe Merge "Log startAtomic()/endAtomic() to the query logger" 2018-10-13 01:45:09 +00:00
Tim Starling
ad32a557fc Log startAtomic()/endAtomic() to the query logger
Change-Id: Ife7e292ef42946ec1c5e9121b7be6a90301b3903
2018-10-13 01:20:32 +00:00
jenkins-bot
a8d422c77f Merge "exception: Correct label "Notice" for E_USER_NOTICE, not "Warning"" 2018-10-13 00:58:16 +00:00
jenkins-bot
238dbaa8f0 Merge "Revert "rdbms: add domain sanity checks to LoadBalancer connection methods"" 2018-10-13 00:58:11 +00:00
Krinkle
f23ac02f4f Revert "rdbms: add domain sanity checks to LoadBalancer connection methods"
This reverts commit b416e166a3.

Fails on Travis CI / PHP 7.1 / Postgres:

> Creating administrator user account
>
> UnexpectedValueException:
> Got connection to 'traviswiki-mediawiki', but expected 'traviswiki'.
>
> Backtrace:
> #0 includes/libs/rdbms/loadbalancer/LoadBalancer.php(887): Wikimedia\Rdbms\LoadBalancer->openForeignConnection(integer, string, integer)
> #1 includes/libs/rdbms/loadbalancer/LoadBalancer.php(766): Wikimedia\Rdbms\LoadBalancer->openConnection(integer, string, integer)
> #2 includes/libs/rdbms/loadbalancer/LoadBalancer.php(851): Wikimedia\Rdbms\LoadBalancer->getConnection(integer, array, string, integer)
> #3 includes/jobqueue/JobQueueDB.php(780): Wikimedia\Rdbms\LoadBalancer->getConnectionRef(integer, array, string, integer)
> #4 includes/jobqueue/JobQueueDB.php(761): JobQueueDB->getDB(integer)
> #5 includes/jobqueue/JobQueueDB.php(187): JobQueueDB->getMasterDB()
> #6 includes/jobqueue/JobQueue.php(332): JobQueueDB->doBatchPush(array, integer)
> #7 includes/jobqueue/JobQueue.php(302): JobQueue->batchPush(array, integer)
> #8 includes/jobqueue/JobQueueGroup.php(154): JobQueue->push(array)
> #9 includes/user/UserGroupMembership.php(162): JobQueueGroup->push(array)
> #10 includes/user/User.php(3733): UserGroupMembership->insert(boolean)
> #11 includes/installer/Installer.php(1680): User->addGroup(string)
> #12 includes/installer/Installer.php(1601): Installer->createSysop(PostgresInstaller)
> #13 includes/installer/CliInstaller.php(176): Installer->performInstallation(array, array)

Change-Id: I269df89d47cc5a183af630447cd1642d3d4a3deb
2018-10-13 00:35:55 +00:00
Krinkle
e4389b7a23 Merge "rdbms: add domain sanity checks to LoadBalancer connection methods" 2018-10-13 00:08:28 +00:00
jenkins-bot
ea286bf7e6 Merge "Avoid global $wgUpdateRowsPerQuery in WatchedItemStore" 2018-10-12 22:35:49 +00:00
jenkins-bot
3d98b80a39 Merge "Add OOUI for HTMLFormFieldCloner" 2018-10-12 22:30:59 +00:00
Roan Kattouw
39e2e85a44 Linker: Document parseComment() as returning HTML
It's not entirely clear from the documentation whether this method
returns wikitext or HTML, so make it explicit.

Change-Id: I094e370e921c43dd8c5dc4376b3dddd803665d90
2018-10-12 15:18:03 -07:00
jenkins-bot
bce87740d7 Merge "Pass LBFactory to WatchedItemStore" 2018-10-12 21:48:54 +00:00
jenkins-bot
95e140cb71 Merge "HtmlTest: Perform multilingual tests" 2018-10-12 18:59:28 +00:00
jenkins-bot
578318e688 Merge "Use a ScopedCallback to silence transaction profiler in SqlBagOStuff" 2018-10-12 18:34:02 +00:00
Erik Bernhardson
1c6e6a4c91 HtmlTest: Perform multilingual tests
The tests here were only testing when user and content language
are the same, but the way things are rendered when they differ
is perhaps more interesting as it allows ensuring the two are used
in the correct places.

Change-Id: I357f50b082882fee485a95323d3a0a7cadb9a63c
2018-10-12 11:24:17 -07:00
Umherirrender
719bfa8977 Use a ScopedCallback to silence transaction profiler in SqlBagOStuff
This affects most LCStoreDB which is the default cache
and spamming the log.

Bug: T154424
Bug: T97693
Change-Id: I68af177c7d0d88ab266eb3fefb4336eff86d861c
2018-10-12 20:04:31 +02:00
C. Scott Ananian
6258e5e55c Deprecate $wgUseKeyHeader and OutputPage::getKeyHeader()
The `Key` header was a draft IETF specification which expired without
becoming a standard.  It does not appear to be in active use anywhere.

Change-Id: I3924a1b5ff428b107573d2827c40e4af8adaaeb1
2018-10-12 13:29:06 -04:00
Umherirrender
1444e77106 Avoid global $wgUpdateRowsPerQuery in WatchedItemStore
Change-Id: Ibff69d16919a595c3edb8e2b431aa42d84a2777a
2018-10-12 13:21:02 +00:00
Umherirrender
98c37e1549 Pass LBFactory to WatchedItemStore
Instead of passing the LoadBalancer and than get the LBFactory from the
service,
store the LBFactory on creation

Bug: T206601
Change-Id: I4c0d3712da591b2c5ddf2a65855d2cc9142417d2
2018-10-12 12:25:28 +00:00
Timo Tijhof
1f92231f81 exception: Correct label "Notice" for E_USER_NOTICE, not "Warning"
Follows-up ef06b528d9, which fixed the severity of all PHP errors
to have severity "Warning" or higher.

However, it also accidentally changed the label of "Notice"
to "Warning", which is confusing and incorrect.

Change-Id: Iffd39aa23b7f2cbff5cdaf876b8d4d595dcd6f96
2018-10-12 05:05:16 +01:00
Aaron Schulz
b416e166a3 rdbms: add domain sanity checks to LoadBalancer connection methods
Bug: T193565
Change-Id: I94d905277e01b8e30ac3f6532ece07388bb20cce
2018-10-12 02:16:49 +00:00
jenkins-bot
4ddc1da854 Merge "Make MergeableUpdate jobs avoid the sub-queue so they can always merge" 2018-10-12 01:13:29 +00:00
jenkins-bot
24f6074430 Merge "Make merged MergeableUpdate items always go to the end of the queue" 2018-10-12 00:58:59 +00:00