Since the latter is going to be removed, make sure that the former has
everything we need. In particular:
- Add failOnRisky=true from suite.xml
- Reorder config options and add comment about stderr from suite.xml
- Remove non-existent tests/phpunit/skins and
tests/phpunit/documentation from the test suites. These cause an error
when trying to run all the suites with `composer phpunit`.
- Leave the other suites as they are. Compared to suite.xml,
phpunit.xml.dist has separate suites for core, extensions, and skins
unit tests.
- Leave includeUncoveredFiles to false. The rationale in
I3d19627fa36f6cc6666c29fdb638272fdaa30630 seems convincing. CI already
sets it to true: https://w.wiki/72qE
- Leave slowThreshold to 100 as per
Ia6ed404d4d4cc8a7b4b8a48b232f644f400f8103. I believe that change
simply missed suite.xml. The same rationale that led to the threshold
being increased for unit tests is valid a fortiori for integration
tests, which are generally slower.
Rename SuiteDirectoryTest and make it check phpunit.xml.dist too.
Bug: T227900
Change-Id: Ib4b47b337870dffc61dd44817a21d11809075d5b
2023-07-14 20:59:42 +00:00
Renamed from tests/phpunit/structure/SuiteDirectoryTest.php (Browse further)
