Commit graph

72 commits

Author SHA1 Message Date
MatmaRex
e7f58fee73 HistoryAction: There is no mediawiki.legacy.history module
Remove the reference to it.

Change-Id: Ia34b2ea6155273faaa8961238e07672f9e65c576
2013-08-10 00:25:20 +02:00
MatmaRex
26060318e8 HistoryPager: Remove superfluous join condition
It is already added by ChangeTags::modifyDisplayQuery().

Change-Id: I00f1f87aa77392a544be50c0298a8d9acb239d4c
2013-07-12 21:30:20 +02:00
jenkins-bot
5b04704d30 Merge "Correctly use $wgFeedLimit in page history feed" 2013-07-11 14:58:19 +00:00
umherirrender
0a810a5a87 Avoid date()/gmdate() for date formatting
Added a MWTimestamp::format method to format a timestamp object in the
given pattern. This avoids date(), which needs the local time
zone corretly set on the server, which is assumed at the moment in
Setup.php

Added MWTimestamp::getInstance for gmdate() and
MWTimestamp::getLocalInstance for date() to create a MWTimestamp object
and use it as inline statement.
Also MWTimestamp::setTimezone and MWTimestamp::getTimzone was added for
timezone handling.

Change-Id: I812aa013be2f4380e0cf10dc465202756fe8347b
2013-07-08 04:14:12 +00:00
MatmaRex
0b7ecb1a64 Correctly use $wgFeedLimit in page history feed
The previous behavior enforced a minimal maximum of 10, even if
$wgFeedLimit was set to a lower value.

Also grepped everything for $wgFeedLimit and fixed all other
error-prone (but correct) uses.

Bug: 50886
Change-Id: Ia81bbadfcf4270b0f932b543265ca37f364530f3
2013-07-07 20:39:53 +02:00
Timo Tijhof
4bd5471ca3 docs: Remove odd colons after @todo
Most were this way already:
https://doc.wikimedia.org/mediawiki-core/master/php/html/todo.html

Ran a find/replace on the odd ones. Also made them all
lower case.

Change-Id: I70c6a69344ddebc603e9a1c1d87e3cc4f4f4c560
2013-05-15 06:23:40 +00:00
umherirrender
1bfc8feb25 Fixed spacing in actions/cache/filebackend/filerepo/job folder
Added spaces before if, foreach
Added some braces for one line statements

Change-Id: Idb93d34e314e5f314223b79208968d6bcd30c40e
2013-04-20 19:18:13 +02:00
umherirrender
15abcf71ca Added/Removed spaces around string concatenation
And added/removed spaces around some other tokens,
like +, -, *, /, <, >, =, !

Fixed windows newline style

Change-Id: I0b9c8c408f3f6bfc0d685a074d7ec468fb848fc8
2013-04-13 13:36:24 +02:00
Siebrand Mazeland
2e0f191829 Use double quotes to use variable $oper properly
Introduced in Change-Id: I29461e5332f3fc6523cbd899e14394aa88865d93

Change-Id: Ic4e8d133fc9ab362f3f463309d799e80fff5d883
2013-04-01 18:25:05 +02:00
Alexandre Emsenhuber
df5265e14d Fix case of some Title methods
Change-Id: I37ce7fe392f4941c500fa0a88007664501d7e338
2013-03-27 14:36:05 +01:00
Kaldari
c5233396cd Changing OutputPage param to a Context param in PageHistoryBeforeList
Change-Id: I348b449043fefba181e28486a07c4aa761bcef24
2013-03-13 21:06:39 +00:00
Kaldari
024ea78574 Adding output parameter to PageHistoryBeforeList hook
This will allow us to easily add other RL modules to the page

Change-Id: I2ec00d44e37298ef91ab428759bda037072b0120
2013-03-12 16:27:16 -07:00
Kaldari
930955762a Adding hooks for thank you notification links
These will allow Echo to add a 'thank' link next to the 'undo' links

Change-Id: Ifb93e49b30bb325ecd17ece9f36bcd83c63a2563
2013-03-12 10:37:39 -07:00
jenkins-bot
6114f05fc1 Merge "Correct case of Title::getPrefixedDBkey() calls" 2013-03-12 15:13:21 +00:00
jenkins-bot
bbd9c84e10 Merge "Documentation improvements in includes/actions" 2013-03-12 15:11:12 +00:00
Tyler Anthony Romeo
4dcc7961df Fixed @param tags to conform with Doxygen format.
Doxygen expects parameter types to come before the
parameter name in @param tags. Used a quick regex
to switch everything around where possible. This
only fixes cases where a primitve variable (or a
primitive followed by other types) is the variable
type. Other cases will need to be fixed manually.

Change-Id: Ic59fd20856eb0489d70f3469a56ebce0efb3db13
2013-03-11 13:15:01 -04:00
Alexandre Emsenhuber
cd4dd7ca85 Correct case of Title::getPrefixedDBkey() calls
Change-Id: Ic9ef0cc6dbb0a8eb0ee93432299ef59759223e2c
2013-03-09 21:14:22 +01:00
umherirrender
d63121016d fix some spacing
Added/removed spaces around logical/arithmetic operator
Reduced multiple empty lines to one empty line
Removed wrong tabs before comments at end of line
Removed too many spaces in assigments

Change-Id: I2bba4e72f9b5f88c53324d7b70e6042f1aad8f6b
2013-03-07 17:53:21 +01:00
Alexandre Emsenhuber
a09a89b48e Documentation improvements in includes/actions
- Separate file and class documentation
- Add some missing class documentation
- Fix erroneous documentation

Change-Id: I35c846ad63e837165b79456dc89d330498aebf64
2013-03-05 16:39:35 +01:00
umherirrender
f97a3a4027 fix some spacing
Change-Id: I670a7baf3ba1e70d18346bb00938d518ba2063bd
2013-02-04 19:59:14 +00:00
jenkins-bot
ec493cc750 Merge "(bug 41330) Default to the current year in the history page filter form" 2013-01-28 18:15:10 +00:00
umherirrender
9824792a75 Remove hardcoded quotes on integer
Change-Id: Ifb1e9777fe1338a5b97d061d80355d51d52ea8da
2013-01-18 19:25:38 +01:00
Marius Hoch
a53fe6f080 (bug 39397) Only show rollback links if they work
To only show rollback links if they work I had to patch Linker
to have a function (Linker::rollbackData) which can verify
that the editor isn't the only editor of the page. Furthermore
it is checked that the user name or the text of the revision
we might rollback to isn't deleted. Due to the fact that I've
altered the already existing method which showed how many edits
a rollback will revert for that, this wont affect the performance.

Change-Id: I5d1adec993370c39ae8c5c712edd919d456441c6
2013-01-09 17:04:44 +01:00
umherirrender
26f13ec28f Use Database::addQuotes instead of hardcoded quotes
Change-Id: I29461e5332f3fc6523cbd899e14394aa88865d93
2013-01-04 20:07:37 +01:00
Brian Wolff
24584cab86 (bug 43379) History page fail gracefully if rev_len unavailable
If the length of a revision is unavailable, do not show
the page size (or char difference) instead of pretending
it is 0 and showing wrong info.

Change-Id: I2b2ca3da480e9222911ff6a91f3ab1ca4a8b9ba1
2012-12-24 10:53:43 +00:00
Alex Monk
1a6de1b24b (bug 41330) Default to the current year in the history page filter form
Change-Id: Ia510f0a24248f95c839ab88062cee1c0c0b9b6c1
2012-12-17 00:59:28 +00:00
Alex Monk
b5a79ed84c (bug 23721) Only show deletedOnly checkbox on contribs and history if the user can see deleted entries
Change-Id: Id47f2883e22a8742d4e5c322c349743e9101f4a3
2012-10-14 02:03:07 +01:00
Siebrand Mazeland
e591bda6fd Fix issue with link in history line for revs hidden from sysops
Looks like this link should have been called $del instead of $cdel.

Needs some verification. Blame came up with Aaron's change in
https://www.mediawiki.org/wiki/Special:Code/MediaWiki/58351. Looks like it may
have been a typo.

Change-Id: I36607e1d1365ddfb0383d68702291509b94a931a
2012-10-08 01:57:15 +02:00
Dereckson
a1e602a939 (bug 40072) Add semantic CSS classes to identify changes list items
In the special pages containing changes list, adding the following
CSS classes to revision rows:
    - mw-changeslist-date
    - mw-changeslist-title
    - mw-changeslist-separator (matching the dots, ". .")

This enhancement has been implemented to the following special pages:
    - [[Special:Contributions]]
    - [[Special:DeletedContributions]]
    - [[Special:RecentChanges]]
    - [[Special:Watchlist]]

It's also implemented on pages history.

Change-Id: I2385ef21d9aed4bdbe4971bfcfa28efaf058e7dd
2012-09-07 22:46:56 +02:00
Alexandre Emsenhuber
701ade0a49 Follow-up I774a89d6 (2fabea7): use $this->msg() in HistoryAction
Change-Id: I308cc8b2e78eab1f2a14b5ade3867216ea3c2525
2012-08-19 08:58:23 +02:00
Siebrand Mazeland
08ba7a001d Fix syntax error.
Change-Id: I76904b609dbc11d11d00bc375ae8587a4ef4848c
2012-08-18 17:11:36 +02:00
Alex Monk
2fabea7eea Use wfMessage instead of deprecated wfMsg*
Or $this->msg in special pages.

Change-Id: I774a89d646615053c8424050e42ad95601f92543
2012-08-18 14:11:05 +02:00
Alexandre Emsenhuber
22f10ef350 For consistency of the interface, don't do expensive checks on page view.
Also replaced two $this->getUser() calls with $user since that variable is
already in that method.

Change-Id: Iccda9f44a9cf6d3187895a8b6111bc62dca1e811
2012-07-14 21:30:49 +02:00
umherirrender
fbc354d110 Use Revision::getParentLengths in history
Using new method from I6e388e75

Change-Id: I902dd1e2699c7291c49cd68fce271941ff4c6e34
2012-07-07 16:45:24 +02:00
Alexandre Emsenhuber
026e8534c6 Add a context parameter to Liker::generateRollback() and Linker::buildRollbackLink() and updated callers.
This allows both methods to not always rely on global object, but also to use the local context when possible.

Change-Id: Id10f55ed9b18c889afd8d9937d9f35acb376cce4
2012-07-05 23:10:03 +02:00
Brad Jorsch
c1bf80f8df (bug 36788) Add classes to containing row on watchlist/history
Each line on the watchlist and on the history pages should have a
specific class to indicate the "updated since my last visit" status,
to allow for more comprehensive styling than is possible with individual
elements embedded within the line.

Also some cleanup: turn the $classes variable in the enhanced watchlist
code path into an array, and change the bolding of titles in the
watchlist from <strong> tags to styling via CSS.

Change-Id: I90bc95db061274d4de782578a4e91f954481adfd
2012-07-01 23:28:21 -04:00
Mormegil
0be8b84299 (bug 15853) Wrong entries in history feed
The history feed for a non-existing page fetched revisions for
rev_page=0. Even though there should be none in the database,
there obviously are, which means such feeds are full of spurious
entries.

Added an existence check, fetchRevisions now returns an empty result
for non-existent pages, which is (and has always been) handled
gracefully in feed() by emitting feedEmpty().

Change-Id: Iae892d900239030bc249c829faecb1bcb3672db2
2012-06-09 23:30:46 +02:00
awjrichards
c29fd59775 Big oops - merged to wrong branch.
Revert "Revert to arbitrarily old point before initial remote branch creation to help clean up"

This reverts commit ee0d3d330f
2012-06-05 22:58:54 +00:00
awjrichards
ee0d3d330f Revert to arbitrarily old point before initial remote branch creation to help clean up
Change-Id: I41a3d1e55d3ea9dffa42451237fe065f9334361d
2012-06-02 08:43:04 -07:00
Liangent
6eac0a40cf setSquidMaxage() globally if we can purge it, instead of in actions.
Change-Id: I404c994616eab0902a9e3650c97028e9bcfb22db
2012-06-04 14:46:36 +08:00
Alexandre Emsenhuber
2c7bf8b8b8 Added missing GPLv2 headers in some places.
Also made file/class documentation more consistent.

Change-Id: Ie95c594fcd686ef30dadc7574d3e5b47236a8638
2012-06-03 22:54:44 +02:00
Kevin Israel
9c349d3176 (bug 35069) Keep history line from ending ' . . '
The portion of the history line after the character difference is now
added immediately before running PageHistoryLineEnding hooks, allowing
the omission of the ' . . ' separator if it would not actually separate
anything but rather remain at the line's end.

Patchset2: Added corresponding release note.

Change-Id: If6458bedb7492b15ece14f5eebbb697b93905a44
2012-04-08 19:15:20 -04:00
Aaron Schulz
d7adc3c373 (bug 34978) Use a rev parent batch query to get the diff sizes for history pages rather than rely on assumptions that break if any filtering is used. 2012-03-13 00:32:47 +00:00
Niklas Laxström
4d94927715 Restore many missing spaces from r112589
Also fixed indentation by spaces
And please don't ever use != ''. It's misleading.
2012-03-01 10:42:02 +00:00
Siebrand Mazeland
481943429e (bug 34702) More localised parentheses. Patch contributed by Yusuke Matsubara. 2012-02-28 11:56:59 +00:00
Sam Reed
386d797d8b Fix extraneous quote from r111800
Doesn't fix Niklas' issue, but it tidies it up for the moment
2012-02-18 14:28:38 +00:00
Andrew Garrett
af668cc7c9 Add both size *and* size difference on history page per bug 34449 2012-02-17 22:49:04 +00:00
Sam Reed
80d2262fae Make wfProfileOut call be the last thing before the return 2012-02-16 02:52:46 +00:00
Mark A. Hershberger
f2ab4aceeb fixes Bug 34198 - first item in the history shows no information about its size
Regression in 1.19 found and fixed by Umherirrender

    With MediaWiki 1.19 the history page was changed from showing the
    size to showing the diff and giving the size in the tooltip.

    But now the first item in the history has no information about it size.
2012-02-11 18:11:01 +00:00
Sam Reed
76246b9bf5 More return documentation 2012-02-09 21:33:27 +00:00