Commit graph

14 commits

Author SHA1 Message Date
Ori Livneh
23c9c5546e Allow RedisConnectionPool to be used with HHVM's Redis library
As of commit 2811e9d, HHVM includes a pure-PHP Redis client library with
method-for-method compatibility with phpredis: <http://git.io/ylDAyQ>.
RedisConnectionPool appears to work well with it save for the
extension_loaded() check. Practically a freebie!

Bug: 54158
Change-Id: I3ac12293a51a45e8f6a61a35bff7a3c063e16964
2013-09-19 10:11:38 -07:00
Antoine Musso
43ae2fb6f9 doc: various updates
[includes/cache/MessageCache.php]
- internal constants
- constructor
- a few missing @var

[includes/clientpool/RedisConnectionPool.php]
- group internal settings applying to the pool
- misc protected members updates

[includes/debug/Debug.php]
- missing parameter name in @var statements

Change-Id: I6ff0a68d659529d128f40f32b0fd1c1d39af952f
2013-05-20 12:02:37 +02:00
Aaron Schulz
3e49fd4af2 Factored JobQueueRedis::redisEval() into RedisConnRef::luaEval().
Change-Id: I1b4bb4f4bb5e25fc3f358c9e2b16e4672584c68b
2013-04-19 01:55:45 +00:00
umherirrender
15abcf71ca Added/Removed spaces around string concatenation
And added/removed spaces around some other tokens,
like +, -, *, /, <, >, =, !

Fixed windows newline style

Change-Id: I0b9c8c408f3f6bfc0d685a074d7ec468fb848fc8
2013-04-13 13:36:24 +02:00
Aaron Schulz
5131bbadd1 Moved some RedisConnectionPool docs to the factory function.
Change-Id: I4183b96e123882de604de1484456abcd10091fb2
2013-03-19 11:15:57 +00:00
Aaron Schulz
a646351d83 Allow having no serializer in RedisConnectionPool.
Change-Id: If367c26b6b19374d1445c406851e2c5d3e5cc634
2013-03-13 14:28:28 -07:00
Aaron Schulz
f399458604 Fixed redis auth error spam in logs.
Change-Id: I52e074b530d4dba2a0a8ec9b7d32f96d4527c6f4
2013-03-11 16:18:25 -07:00
Aaron Schulz
45e72198d9 Fixed connection comparison in RedisConnectionPool::handleException().
* This was comparing a Redis with a RedisConnRef.

Change-Id: I6353736c8ad42a18d90e8474d38398d305950346
2013-03-11 22:57:33 +00:00
Tyler Anthony Romeo
4dcc7961df Fixed @param tags to conform with Doxygen format.
Doxygen expects parameter types to come before the
parameter name in @param tags. Used a quick regex
to switch everything around where possible. This
only fixes cases where a primitve variable (or a
primitive followed by other types) is the variable
type. Other cases will need to be fixed manually.

Change-Id: Ic59fd20856eb0489d70f3469a56ebce0efb3db13
2013-03-11 13:15:01 -04:00
Aaron Schulz
646051d36d Removed "poolSize" option from RedisConnectionPool.
* The size is now automatically based on the number of servers.

Change-Id: I6ea53378c9c8254e8556c0a1e4efe64fd71ba356
2013-03-08 06:38:50 +00:00
Aaron Schulz
1ca99fa957 Resolve config defaults in RedisConnectionPool in the singleton().
* This can avoid fragmentation when applying defaults to different
  config arrays actually gives the same resulting array.

Change-Id: Iacab8d38080f51eb3f331d55a8535eed6d93b381
2013-03-01 14:55:22 -08:00
Aaron Schulz
7e6ad48641 Avoid pool fragmentation in RedisConnectionPool.
* Avoid fragmenting the client pools due to "poolSize" differences.
  Instead that config parameter does not affect the pool something uses,
  but the pool used will grow to fit the pool size of anything using it.

Change-Id: Ibc9db7cfc277824b1acde5e6fbf1db0ed296cb41
2013-02-26 20:47:27 +00:00
Aaron Schulz
abd562162c Fixed some comments and removed redundant constant.
* Also normalized params in RedisConnectionPool to avoid fragmentation.

Change-Id: I803dae52262b974836817d2091725f044faf7022
2013-02-11 10:11:52 -08:00
Aaron Schulz
03833b54e8 [JobQueue] Added a JobQueueRedis class.
* The Job class now includes an extra "metadata" field now for usage
  by the queue classes. This is useful for stores that lack IDs.
* A RedisConnectionPool class was added for reusability.

Change-Id: Ie72536240e27fe1caf11096cdc4c85dfa821d181
2013-01-22 11:09:58 -08:00