Commit graph

384 commits

Author SHA1 Message Date
Alexandre Emsenhuber
5700f36de1 * (bug 22867) "View source" tab is now only displayed if there's source text
* Removed comment which is no longer true since the new localisation cache
2010-04-02 08:00:40 +00:00
Jack Phoenix
f624235d70 move newtalk stuff from SkinTemplate to its own function in Skin 2010-03-23 16:11:37 +00:00
Alexandre Emsenhuber
b8b254da7f Fixes to r62995:
* Avoid fatal error if $wgProfiler is either not a object (ProfilerStub.php) or an instance of Profiler
* Set $wgProfiler to null in ProfilerStub.php so that $wgProfiler doesn't need to be checked with "isset" first, updated check in GlobalFunctions.php accordingly
2010-02-26 08:53:06 +00:00
Mark A. Hershberger
c6bb90b4c7 fixes bug 20388; follow up r60216. Make sure ProfilerSimpleText output only appears on templated/html output, not action=raw or atom output 2010-02-26 04:48:47 +00:00
Aryeh Gregor
643866f8b7 War on xml:lang
There is no reason to use this in HTML in addition to the lang
attribute.  No spec requires it (AFAIK) and it's completely redundant.
2010-02-11 17:25:10 +00:00
Aryeh Gregor
e2087f07ca Avoid silly markup like <ul > 2010-02-11 17:25:03 +00:00
Tim Starling
1f42153b5c Revert r61005, r61047 (show copyright message on special pages). Maybe this could be configurable and off by default, but I'd be just as happy with an idiosyncratic change like this being a local patch. 2010-01-26 03:10:44 +00:00
Aryeh Gregor
010c456825 Merge all skins' output of opening <body> tag
This fixes a few minor discrepancies, like Vector outputting dir=""
(redundant to the one on <html>), and non-Monobook-based skins omitting
the capitalize-all-nouns class (!).  This adds Html::openElement() and
refactors Html::rawElement() accordingly, so I checked that all parser
tests still pass.

I wasn't able to figure out if I broke some feature of right-floating
quickbars in the Standard skin, because I wasn't able to figure out what
the feature was in the first place.  Hopefully either it works, or
nobody cares, or someone else will figure out what it was supposed to
do.  (This is the stuff in getBodyOptions() in Standard.php I deleted;
I'm not sure the addition to sticky.js does what I want.)
2010-01-15 01:16:52 +00:00
Aryeh Gregor
6f77ad2c24 Remove body_onload, was always set false anyway 2010-01-15 00:12:39 +00:00
Sam Reed
83cc0ac5ae Fixup r61005, seems i failed at applying the patch 2010-01-14 10:11:45 +00:00
Sam Reed
4e907bc018 * (bug 16281) Show copyright system message on special pages
Patch by Jools Wills
2010-01-13 13:14:02 +00:00
Bryan Tong Minh
b024a2be35 Followup r58980: Moved logic for addsection-editintro/preload from SkinTemplate to EditPage.
Message names changed from talk-addsection-* to addsection-*.
Messages now contain the preload/editnotice themselves instead of the title of the page that contains them.
2010-01-11 11:47:50 +00:00
Mark A. Hershberger
4c2b354e1e follow-up 60833
because I'm an idiot.
2010-01-08 08:55:00 +00:00
Mark A. Hershberger
632e01fbd4 follow up r60829
Gah — really need to get E_STRICT working in my test environment.
2010-01-08 08:49:01 +00:00
Mark A. Hershberger
df100abc94 Follow up r60798 & r60785
Re-introduce specialpageattributes and add an explanation in the comments why it should be different than userlangattributes.  Also add comments explaining exactly what is going with the special attributes and why.  Clean up warnings.
2010-01-08 03:34:04 +00:00
Trevor Parscal
41dbba42fb In r60786 mah added 'specialpageattributes' to the skin, only in the case of the title being a special page, and filled it with the same information as 'userlangattributes'. Then added some uses of 'specialpageattributes' to all three SkinTemplate based skins, which were using that data on all pages - resulting in an error. This corrects this problem. 2010-01-07 18:59:07 +00:00
Mark A. Hershberger
add6090790 Make LTR wgLang do the right thing on RTL wgContLang wikis. See bug 6100 and dupes like bug 4047, bug 19228, bug 9137, etc. 2010-01-07 09:32:09 +00:00
Sam Reed
b6e0df246f Attempt at normalistion of comparison styles - empty string on left and right hand side normalised to it being on the rhs
Before this change, there were (? being regex 0 or 1)

"" ===? 1
'' ===? 24
"" !==? 8
'' !==? 32

== "" 14
== '' 344
!= "" 9
!== "" 4
!= '' 151
!== '' 85


Rhs was the much more common, and the preferred style by many developers.. (Was a similar discussion in #mediawiki recently.. After that lolbugreport i think)

Where there is a string (non empty) on the lhs, and variable/method call on the rhs still need normalising
2010-01-06 19:59:42 +00:00
Bryan Tong Minh
312394f35b Fix for r58980: use wfMsgForContent 2010-01-02 15:03:17 +00:00
Chad Horohoe
a4e5e935b6 Mass convert NULL -> null. Left strings and comments alone, obviously. 2009-12-11 21:07:27 +00:00
Alexandre Emsenhuber
6af1a3d25e * (bug 21650) Both calls to SkinTemplateTabs hook are now compatible 2009-11-26 20:19:09 +00:00
Daniel Kinzler
8500fd8005 add a version attribute to the <html> tag if RDFa is used with HTML5 2009-11-13 21:58:39 +00:00
Bryan Tong Minh
293f574a1e * (bug 17662) Customizable default preload/editintro in add-new-section link for Talk page. Patch by ireas. 2009-11-12 22:35:25 +00:00
Chad Horohoe
6afbf91101 bug 9982. Encapsulate wgCanonicalNamespaceNames. Patch by Scott Colcord, with updates 2009-10-16 04:06:30 +00:00
Aaron Schulz
c2f7ea4d7b * Renamed deletedcontent to deletedtext
* Removed deletedrevision and used deletedhistory/deletedtext instead
2009-09-30 19:50:35 +00:00
Aaron Schulz
55493e2a05 * Split out 'deletedcontent' from 'undelete' right (bug 19199/bug 9884)
* Don't blue-link unviewable hidden revisions
2009-09-22 22:30:09 +00:00
Alexandre Emsenhuber
0b5389d98d * (bug 20631) Preview of personal JavaScript and CSS pages now works again
* introduced SkinTemplate::$useHeadElement as switch for backward compatibility for extension skins using the old way of generating the <head> element:
** false (default): no change from previous version
** true: <head> specific items set in SkinTemplate::outputPage() are no longer generated (avoid double execution of some functions) and the result of OutputPage::headElement() is stored in the 'headelement' item
* updated all core skin to use this new method, some extensions using MonoBookTemplate but not extending SkinMonoBook (or for other core skins) will need to set $useHeadElement to true to work properly though
* Made Skin::userCanPreview() public since it's needed in OutputPage::getHeadScripts()
* Pass the Skin object from OutputPage::headElement() to OutputPage::getHeadScripts() rather than getting it from $wgUser
2009-09-22 16:52:40 +00:00
Michael Dale
7496a8e6c5 * (bug 20720) moved userjs and sitejs to after core scripts and before all extension code.
* removed setupSkinUserJs (not called anywhere) same functionality in getHeadScripts
* moved Skin::getHeadScripts() to outputPage::getHeadScripts() 
** ( part of an effort to clean up scripts insertion to OutputPage ) 
** Standard skin was the only skin that implemented the getHeadScripts method. Has been merged into a skin::OutputPage method.
2009-09-22 01:00:06 +00:00
Alexandre Emsenhuber
6f9f6643d7 * indent debug output produced when both $wgShowDebug and $wgDebugFunctionEntry are enabled for better readability. In this case, unindented comment will be displayed "inline" with a yellow background
* added an id to the debug data list
* allow to use $wgShowDebug with $wgDebugComments set to false
* update HTMLFileCache to use full method name in debug output
2009-09-17 18:55:29 +00:00
Tim Starling
7b7f9f0d4d Comments and whitespace fixes only. 2009-09-10 06:43:01 +00:00
Alexandre Emsenhuber
11512c043e Per Brion's comment on r52683: use $wgOut->isPrintable() rather than $wgRequest->getBool( 'printable' ) 2009-08-22 22:26:31 +00:00
Brion Vibber
71432fb487 Pet peeve time: reduce clutter from common $wgContLang->isRTL() ? 'x' : 'y' pattern. :)
Introduced helpers:
  $lang->getDir() returns 'ltr' or 'rtl' for HTML 'dir' attrib
  $lang->alignStart() returns 'left' or 'right' for HTML 'align' attrib or CSS 'text-align' property
  $lang->alignEnd() returns 'right' or 'left'

And cleaned up a couple arrays of icons to just reverse the order of items rather than repeating the items twice for each possibility.
2009-08-22 01:24:04 +00:00
Roan Kattouw
7381c2b296 Follow-up to r54556: fix login/logout links in core 2009-08-17 20:28:24 +00:00
Tim Starling
0694c5aa90 (bug 20170) Make QuickTemplate::execute() abstract, instead of sending a dorky PHP 4-style error message to the user. 2009-08-11 06:02:06 +00:00
Brion Vibber
de495fa427 Pull back r54590, r54591, r54628, r54633, r54636, r54714 "Add after the link for "My Talk" "<number of new messages(edits)>" if there are some"
The number of edits doesn't correspond terribly well with "number of messages". Recommend leaving this for future when we actually have sensible message semantics.
2009-08-10 19:03:33 +00:00
Jan Luca Naumann
297b813cbb (r54628 + r54633) Display (...) only if there new messages 2009-08-10 11:29:33 +00:00
Jan Luca Naumann
33468645eb fixes for r54633: Add wfMsgExt for parsing PLURAL in message "newmessagesdifflink" 2009-08-08 17:34:12 +00:00
Jan Luca Naumann
f6ff314f05 (fixes for r54628) Add PLURAL to "last change" message 2009-08-08 16:02:30 +00:00
Jan Luca Naumann
aca7cbdebe (fixes for r54590 & bug 20103) Use now only one query and add number to messages "youhavenewmessages" and "mytalk" 2009-08-08 10:37:34 +00:00
Jan Luca Naumann
fcb5f2111c Add after the link for "My Talk" "<number of new messages(edits)>" if there are some 2009-08-07 16:39:35 +00:00
Roan Kattouw
775154ca21 Fix r53270: drop &returntoquery parameter if empty, and prevent Special:Userlogin from returning to itself, creating very long looplike URLs 2009-07-26 10:34:03 +00:00
Aryeh Gregor
0df8b0afcd Use member variable defaults for SkinTemplate 2009-07-20 00:33:23 +00:00
Roan Kattouw
8d31e8d8a0 Fix encoding issue in r53270 2009-07-15 10:22:56 +00:00
Niklas Laxström
3cf4ba377a Couple of issues in r53270: use accessor method and keep the function signature bc 2009-07-15 06:43:42 +00:00
Michael Dale
aefc40d749 here it is ... the upload-api, script-server, js2 (javascript phase2) branch merge 1st attempt.
Here is a short overview of changes and associated default configuration variables (most everything is off by default) also see ~soon to be updated~: http://www.mediawiki.org/wiki/Media_Projects_Overview

= Upload Improvements =
==Upload API ==
* Based on the early work of Bryan Tong and others it adds the upload option to the api.
* We rewrite Special:Upload page to include use the new refactoring
* Added in token checks in both the SpecialUpload.php page so avoids DOS / xss copy-by-url JavaScript based cross site POST file submissions

== Copy by URL==
$wgAllowCopyUploads = false;
* http class rewrite includes a new http background download see: includes/HttpFunctions.php

* spins off a php process that calls: maintenance/http_session_download.php
* pushes updates to the session and gives the user a progress bar on http copy uploads from other server progress (using js2 upload interface) (if not using the js2 upload interface it does the request in-place but the download is limited to the php ini timeout time)

== Firefogg ==
* Firefogg enables resumable upload by chunks
* progress indicators and conditional invokation (js2 system)
* and of-course client side transcoding.

= Script Server =
$wgEnableScriptLoader = false;
* off by default if $wgEnableScriptLoader is turned on script files are grouped, gziped, cached etc.
for more info see: http://www.mediawiki.org/wiki/Extension:ScriptLoader

* Includes some early skin js include fixes (skin/script system still lots of love)
* Includes a "javascript class autoloader" this is packaged into mwEmbed so that the mwEmbed library can work in stand alone mode (while retaining localization and script serving) (one such application is the make page for firefogg.org : http://www.firefogg.org/make/index.html  )
* The file that contains the autojavascript loading classes is: js2/php/jsAutoloadLocalClasses.php
* One can use this auto class loading dependency system with extensions and add-ons but I need to better document that.

= js2 system  / mwEmbed=
$wgEnableJS2system = false

* includes initial rewrite towards more jquery based javascript code
* especially for the Special:Upload page.
* Also the edit page include support for the "add-media-wizard"
* includes dependency loader for javascript that optionally takes advantage of the script-loader
* remote embedding of javascript interfaces (like embedding video, or commons media searching)

* $wgDebugJavaScript = false; .. .this variable lets you always get "always fresh javascript". When used with the script-loader it does not minify the script-loader output.

= mwEmbed =
* Will commit a separate patch to oggHandler that conditionally outputs  <video tag> to use the new javascript video player.
** mv_embed player includes: play-head, volume control, remote embedding, oggz-chop support across plugins.
* add-media-wizard adds easy inserts of media to pages (with import)

== jQuery==
* we include a base install of jQuery, jQuery ui and some plugins.
* all the javascript classes are in the scriptloader so its easy to load any set of jquery ui components that you may need using the script-server. You get a callback so you can then execute js with dependencies loaded.

== other stuff ==
there is a bit more code in js2 that pertains to sequence editing, timed text display and basic image editing. We include a base import of pixastic-lib & pixastic-editor... will work with the pixastic developer to try and ensure upstream compatibility on our usage of the library for in-browser photo and sequence manipulation.
2009-07-14 23:52:14 +00:00
Roan Kattouw
7a7cf1a2f9 Add returntoquery= parameter to Special:Userlogin which adds a query string to the "Return to" link. Also using this parameter in the Log in and Log out links on top of the screen, so that people who click Log in from e.g. an edit page will be taken back to the edit page rather than to the page view. 2009-07-14 21:25:33 +00:00
Trevor Parscal
acb0bf6bc4 Moved buildNavigationUrls back into Vector to make deployment more sane for now - this action will likely be reversed in the future when head is deployable. 2009-07-13 22:14:43 +00:00
Niklas Laxström
875063589d Some escaping fixes and related readability changes 2009-07-13 10:34:31 +00:00
Trevor Parscal
ff71b57660 Moved buildNavigationUrls into SkinTemplate from SkinVector which inherits SkinTemplate - as was originally intended. 2009-07-08 20:59:59 +00:00
Aryeh Gregor
c4012b03bc Unify MonoBook <head> generation with legacy skins
This was less work than I thought it would be.  The only possible
practical difference in MonoBook should be that some IE fixes are moved
down; at a glance, I don't see how this would hurt anything, but if it
does then some more hacks can be added to move them back up.

A bunch of whitespace was changed in both MonoBook and legacy skins.
Legacy skins had some stuff moved around in the <head>, but mainly to
better match MonoBook, so they should work better if anything, not
worse.  dir= was added to the <body> in legacy skins, matching MonoBook.
There should be no other practical differences.

I would strongly encourage people to port the Modern and Vector skins to
at least share the <head>-generation code like this.  I'd even more
strongly encourage people to totally rewrite the skin system, but that's
a bigger job.  :)
2009-07-07 21:49:45 +00:00