Greg Sabino Mullane
0e5f0e043b
Support looking up deferred constraint information.
2010-03-22 18:14:25 +00:00
Tim Starling
ea93933ee9
* Fixed complete breakage of "lag.php -r" due to spurious line-endings introduced in maintenance-work.
...
* Fixed breakage due to lag time cache, based on a hack in the WMF working copy.
* Tested locally.
2010-03-18 05:23:46 +00:00
Alexandre Emsenhuber
1e2840cd31
Fixed some errors while running patchSql.php:
...
* Notice: Undefined variable: name in includes/db/Database.php on lines 2209 and 2212
* Fatal error: Call to undefined method DatabaseMysql::fileSource() in maintenance/patchSql.php on line 48
2010-03-14 15:48:29 +00:00
Alexandre Emsenhuber
54fd0a4c1f
Fixed some doxygen warnings
2010-03-11 20:59:25 +00:00
Mark A. Hershberger
564dafbdcf
whitespace.
2010-03-06 18:14:11 +00:00
Max Semenik
fce6a52cf9
Fix r63320
2010-03-06 16:45:48 +00:00
Max Semenik
e78af18401
Fixed a couple of E_DEPRECATED in DatabaseMssql
2010-03-06 16:39:31 +00:00
Jure Kajzer
d43a5844dd
oracle: missing table prefix
2010-03-02 16:58:21 +00:00
Jure Kajzer
29544758f1
tableName calls moved inside fieldInfoMulti and removed call that existed only for this call
2010-02-23 10:38:06 +00:00
Max Semenik
5426f6e6a7
Also rewrite ALTER TABLE, handle int(...) properly
2010-02-21 09:40:27 +00:00
Max Semenik
83323b3e13
DatabaseSqlite:
...
* Tweaks and fixes to DDL conversion from MySQL. Now everything in tables.sql converts cleanly to SQLite's native type hints.
* Handle error in duplicateTableStructure().
2010-02-20 20:00:28 +00:00
Alexandre Emsenhuber
a3d4855413
Fix for r62744: use tabs for indentation, not spaces
2010-02-20 19:22:27 +00:00
Jure Kajzer
ec7782fe97
tableName has to be encoded before field type checking
2010-02-20 18:27:00 +00:00
Alexandre Emsenhuber
84d7ab97e3
Fix doxygen warnings
2010-02-05 18:28:40 +00:00
OverlordQ
76e2c017c4
Force new connection to database, fixes bug 20475, might have unforseen consequences
2010-02-05 05:40:50 +00:00
Max Semenik
2207d96cab
DatabaseSqlite: avoid fatals with non-zero $failFunction
2010-02-03 19:55:56 +00:00
Jure Kajzer
8fcb7e42a1
Fixed as per Tim's comments on r61179:
...
* made insertOneRow and getSequenceData private
* renamed fieldInfo to fieldInfoMulti and made it private (for internal use on Oracle only)
* wrapped fieldInfoMulti in fieldInfo with error if $table parameter is an array
* reverted tableName function to only support a non-array parameter
* wrapped all tableName calls with array parameter with array_map with callback
* wrapped fieldInfo into textFieldSize function to avoid reimplementation of functionality
* fixed unnessesary multiple calls to tableName with same parameter inside a single procedure
2010-01-28 14:58:45 +00:00
Max Semenik
6c7bb57316
Special delivery for Nikerabbit: ability to connect to a SQLite db file directly, no foreplay with global settings needed.
2010-01-22 21:30:23 +00:00
Max Semenik
eff719b75d
Fixed r61214: moved MySQL munging to SearchEngine, updated calls. Can we kill $doStrip now?
2010-01-22 20:36:26 +00:00
Platonides
33917224dc
(bug 21870) Remove Google logo loaded from it servers (privacy concern).
...
The form is now left as googlesearch message. We should probably remove the duplication and load it with wfMsgWeirdKey.
2010-01-20 22:01:37 +00:00
Jure Kajzer
3707fcc2f8
Fixed as per Tim's comments on r60665:
...
* fieldExists reduced to bool-cast output of fieldInfo
* added negative cache (handled acordingly on fieldInfo usage)
* uppercased parameters on entry. DB data is uppercased by default
2010-01-20 16:19:08 +00:00
Max Semenik
f6dee6c1e7
Factored MySQL-specific munging out of Language::stripForSearch() to DatabaseMysql. This will also allow other backends to provide seamlessly their own munging algorithms in the future.
2010-01-18 20:54:43 +00:00
Max Semenik
b82e6766e5
rv bit accidentally committed in r61180
2010-01-18 17:54:37 +00:00
Max Semenik
f3998d502e
Ran stylize.php on DatabaseSqlite
2010-01-17 20:47:23 +00:00
Jure Kajzer
0e361f492b
Fixed error suppressing suggested in r58559 by Tim. Also fixed some warnings and bugs in Oracle abstraction.
2010-01-17 20:42:54 +00:00
Tim Starling
9a420fa847
Remove code commented out by r58597
2010-01-11 00:55:21 +00:00
Aryeh Gregor
70f749ba75
Use string interpolation, not .
...
Prompted by r60731, although that didn't actually add the concatenation
(which should have had more spaces, too).
2010-01-10 23:24:47 +00:00
Max Semenik
f6cb1b0442
Workaround for SQLite's inability to perform multi-row replacements
2010-01-10 17:27:46 +00:00
Jure Kajzer
f488d7de97
Prevented delete call in replace function if conditions empty. Removed some old commented code.
2010-01-08 07:23:43 +00:00
Tim Starling
fd3794c5bc
For r60757: implement Database::getType() explicitly in each subclass, to make Roan happy.
2010-01-08 00:31:24 +00:00
Tim Starling
071bbbe218
Add a Database::getType() function so that we can get rid of $wgDBtype in favour of OOP goodness.
2010-01-07 00:22:18 +00:00
Niklas Laxström
aca2d0faef
Add comment about unused parameters to constructor too + coding style
2010-01-06 22:19:48 +00:00
Sam Reed
b6e0df246f
Attempt at normalistion of comparison styles - empty string on left and right hand side normalised to it being on the rhs
...
Before this change, there were (? being regex 0 or 1)
"" ===? 1
'' ===? 24
"" !==? 8
'' !==? 32
== "" 14
== '' 344
!= "" 9
!== "" 4
!= '' 151
!== '' 85
Rhs was the much more common, and the preferred style by many developers.. (Was a similar discussion in #mediawiki recently.. After that lolbugreport i think)
Where there is a string (non empty) on the lhs, and variable/method call on the rhs still need normalising
2010-01-06 19:59:42 +00:00
Jure Kajzer
7fc32afd48
Fixed variable name typo from r60665. (problems while sending file in previous attempt r60730)
2010-01-06 14:00:17 +00:00
Jure Kajzer
12e9352062
Fixed variable name typo from r60665.
2010-01-06 13:52:58 +00:00
Tim Starling
ddd5acf900
Don't count unions of bracketed selects as being write queries
2010-01-06 04:05:49 +00:00
Mark A. Hershberger
9ef63ede49
Random eol whitespace found while treking through files.
...
Removing unused call to $wgContLang->getFormattedNsText() from addNewUserLogEntry()
2010-01-06 03:42:30 +00:00
Roan Kattouw
af3fd687db
Add $maxlag parameter to LoadBalancer::getMaxLag() so it'll actually select the right DB when opening new connections. Looks like an ugly temp fix to me but I have no idea how to do it properly offhand.
2010-01-05 23:39:16 +00:00
Jure Kajzer
98aedd07b3
fixme for r58356
2010-01-05 13:35:19 +00:00
Chad Horohoe
291efd30f2
Followup r60051, with the rest of the callers and removing a useless subclassing from DatabaseMssql
2009-12-14 23:18:03 +00:00
Chad Horohoe
b19e37425a
Update callers from immediateCommit() to commit(). The former's been deprecated a really long time...Tim did it 45243 revisions ago.
2009-12-14 23:05:35 +00:00
Chad Horohoe
a4e5e935b6
Mass convert NULL -> null. Left strings and comments alone, obviously.
2009-12-11 21:07:27 +00:00
Max Semenik
25009de080
Per CR for r58631, moved default duplicateTableStructure() implementation to DatabaseMysql, replacing it with 'not implemented' exception throw
2009-12-11 19:53:10 +00:00
Jack Phoenix
7a1448b4f0
more coding style cleanup to DatabaseOracle.php
2009-12-11 18:23:24 +00:00
Jure Kajzer
1600e22d14
Fixed missing table in ora/tables.sql. Replaced instantiation of DBUndexpecedError with DBQueryError in reportQueryError function
2009-12-11 16:47:06 +00:00
Aryeh Gregor
d5c5375ec4
stylize.php on DatabaseOracle.php
...
Please follow <http://www.mediawiki.org/wiki/Manual:Coding_conventions >
so that code is easier to read. (For anyone whose blames are getting
messed up by whitespace changes, use svn blame -x -w, or git blame -w,
to ignore them.)
2009-12-10 23:22:34 +00:00
Tim Starling
c5fc589257
Replaced all instances of <<<END (which breaks vim syntax highlighting), with a type-specific end token. For HTML and SQL, this causes vim to highlight the embedded text with the HTML or SQL file type plugins respectively, which is very neat.
2009-12-07 08:51:52 +00:00
Max Semenik
a9927b34c5
Fixed duplicateTableStructure() for SQLite, it previously didn't copy row properties such as autoincrement. Resolves bug 20549 - parser tests now work with SQLite.
2009-12-06 11:09:39 +00:00
Tim Starling
bd8fffe24d
Reverted r58646 as per my comments on bug 20554.
2009-12-01 01:55:04 +00:00
Greg Sabino Mullane
bc1196170d
Typo.
2009-11-27 15:19:05 +00:00
